Re: [Qemu-devel] Re: [kvm-devel] expose host CPU features to guests

2007-09-07 Thread Jamie Lokier
Anthony Liguori wrote: I like this idea but I have some suggestions about the general approach. I think instead of defining another machine type, it would be better to just have a command line option like -cpuid that took a comma separate string of features with all meaning all features that

Re: [Qemu-devel] Re: [kvm-devel] expose host CPU features to guests

2007-09-06 Thread Avi Kivity
Paul Brook wrote: I think qemu-cvs has a -cpu option for non-x86 which could be used for this. Agree machine types are the wrong approach. Yep, machine types are already used to switch between a different concept so using the new -cpu option would make sense. Could perhaps extend the

[Qemu-devel] Re: [kvm-devel] expose host CPU features to guests

2007-09-05 Thread Anthony Liguori
On Wed, 2007-09-05 at 20:45 +0300, [EMAIL PROTECTED] wrote: Hi, It's a pity not to use a host CPU feature if it is available. This patch exposes host CPU features to guests. It allows fine-tuning the presented features from the command-line. The code could use some serious clean ups, but

[Qemu-devel] Re: [kvm-devel] expose host CPU features to guests

2007-09-05 Thread Avi Kivity
Anthony Liguori wrote: On Wed, 2007-09-05 at 20:45 +0300, [EMAIL PROTECTED] wrote: Hi, It's a pity not to use a host CPU feature if it is available. This patch exposes host CPU features to guests. It allows fine-tuning the presented features from the command-line. The code could use some

[Qemu-devel] Re: [kvm-devel] expose host CPU features to guests

2007-09-05 Thread Daniel P. Berrange
On Wed, Sep 05, 2007 at 10:34:45PM +0300, Avi Kivity wrote: Anthony Liguori wrote: On Wed, 2007-09-05 at 20:45 +0300, [EMAIL PROTECTED] wrote: Hi, It's a pity not to use a host CPU feature if it is available. This patch exposes host CPU features to guests. It allows fine-tuning the

Re: [Qemu-devel] Re: [kvm-devel] expose host CPU features to guests

2007-09-05 Thread Paul Brook
I think qemu-cvs has a -cpu option for non-x86 which could be used for this. Agree machine types are the wrong approach. Yep, machine types are already used to switch between a different concept so using the new -cpu option would make sense. Could perhaps extend the syntax so that