Re: [Qemu-devel] Re: new->old version migration

2011-02-08 Thread Michael S. Tsirkin
On Tue, Feb 08, 2011 at 01:42:59AM -0600, Anthony Liguori wrote: > On 02/08/2011 12:42 AM, Michael S. Tsirkin wrote: > >On Mon, Feb 07, 2011 at 08:23:08PM -0600, Anthony Liguori wrote: > >>On 02/07/2011 03:52 PM, Michael S. Tsirkin wrote: > >>>How does it? We need to know we are saving in 0.13 > >>

Re: [Qemu-devel] Re: new->old version migration

2011-02-07 Thread Amit Shah
On (Tue) 08 Feb 2011 [01:44:32], Anthony Liguori wrote: > On 02/08/2011 01:07 AM, Amit Shah wrote: > >On (Tue) 08 Feb 2011 [08:42:14], Michael S. Tsirkin wrote: > >>I see. I'm unhappy with the facts that > >>1. if (feature) is spread all over the code instead > >>of just in migration > >>2. it

Re: [Qemu-devel] Re: new->old version migration

2011-02-07 Thread Anthony Liguori
On 02/08/2011 12:42 AM, Michael S. Tsirkin wrote: On Mon, Feb 07, 2011 at 08:23:08PM -0600, Anthony Liguori wrote: On 02/07/2011 03:52 PM, Michael S. Tsirkin wrote: How does it? We need to know we are saving in 0.13 format and skip the new subsection, otherwise 0.13 will see a subsect

Re: [Qemu-devel] Re: new->old version migration

2011-02-07 Thread Anthony Liguori
On 02/08/2011 01:07 AM, Amit Shah wrote: On (Tue) 08 Feb 2011 [08:42:14], Michael S. Tsirkin wrote: I see. I'm unhappy with the facts that 1. if (feature) is spread all over the code instead of just in migration 2. it is also obfuscated with if (flow_control) instead of plain if (mig

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Amit Shah
On (Tue) 08 Feb 2011 [08:42:14], Michael S. Tsirkin wrote: > I see. I'm unhappy with the facts that > 1. if (feature) is spread all over the code instead >of just in migration > 2. it is also obfuscated with if (flow_control) >instead of plain if (migrate to qemu < 0.14) >so removing it

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Michael S. Tsirkin
On Mon, Feb 07, 2011 at 08:23:08PM -0600, Anthony Liguori wrote: > On 02/07/2011 03:52 PM, Michael S. Tsirkin wrote: > >How does it? We need to know we are saving in 0.13 > >format and skip the new subsection, otherwise > >0.13 will see a subsection it does not recognize > >and exit. > > If you us

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Anthony Liguori
On 02/07/2011 03:52 PM, Michael S. Tsirkin wrote: How does it? We need to know we are saving in 0.13 format and skip the new subsection, otherwise 0.13 will see a subsection it does not recognize and exit. If you used subsections for flow control, presumably you would only send the new sav

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Michael S. Tsirkin
On Mon, Feb 07, 2011 at 02:56:50PM -0600, Anthony Liguori wrote: > On 02/07/2011 01:53 PM, Michael S. Tsirkin wrote: > >On Mon, Feb 07, 2011 at 01:33:57PM -0600, Anthony Liguori wrote: > >>On 02/07/2011 10:07 AM, Michael S. Tsirkin wrote: > >>>New thread stated intentionally, the original patch is

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Anthony Liguori
On 02/07/2011 01:53 PM, Michael S. Tsirkin wrote: On Mon, Feb 07, 2011 at 01:33:57PM -0600, Anthony Liguori wrote: On 02/07/2011 10:07 AM, Michael S. Tsirkin wrote: New thread stated intentionally, the original patch is Message-ID: <349e93a4cfc6e1effc1b681cae53f805fdb9624e.1296713825.

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Alex Williamson
On Mon, 2011-02-07 at 18:07 +0200, Michael S. Tsirkin wrote: > New thread stated intentionally, the original patch is Message-ID: > <349e93a4cfc6e1effc1b681cae53f805fdb9624e.1296713825.git.amit.s...@redhat.com> > > On Thu, Feb 03, 2011 at 11:47:08AM +0530, Amit Shah wrote: > > Add a compat propert

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Michael S. Tsirkin
On Mon, Feb 07, 2011 at 01:33:57PM -0600, Anthony Liguori wrote: > On 02/07/2011 10:07 AM, Michael S. Tsirkin wrote: > >New thread stated intentionally, the original patch is Message-ID: > ><349e93a4cfc6e1effc1b681cae53f805fdb9624e.1296713825.git.amit.s...@redhat.com> > > > >On Thu, Feb 03, 2011 at

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Anthony Liguori
On 02/07/2011 10:07 AM, Michael S. Tsirkin wrote: New thread stated intentionally, the original patch is Message-ID: <349e93a4cfc6e1effc1b681cae53f805fdb9624e.1296713825.git.amit.s...@redhat.com> On Thu, Feb 03, 2011 at 11:47:08AM +0530, Amit Shah wrote: Add a compat property for older mach

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Anthony Liguori
On 02/07/2011 10:51 AM, Michael S. Tsirkin wrote: On Mon, Feb 07, 2011 at 09:40:14AM -0700, Alex Williamson wrote: On Mon, 2011-02-07 at 18:07 +0200, Michael S. Tsirkin wrote: New thread stated intentionally, the original patch is Message-ID: <349e93a4cfc6e1effc1b681cae53f805fdb9624e.

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Michael S. Tsirkin
On Mon, Feb 07, 2011 at 09:40:14AM -0700, Alex Williamson wrote: > On Mon, 2011-02-07 at 18:07 +0200, Michael S. Tsirkin wrote: > > New thread stated intentionally, the original patch is Message-ID: > > <349e93a4cfc6e1effc1b681cae53f805fdb9624e.1296713825.git.amit.s...@redhat.com> > > > > On Thu,