[Qemu-devel] Re: sparc32 fix spurious dma interrupts v2

2010-02-15 Thread Blue Swirl
Thanks, applied. On Mon, Feb 15, 2010 at 7:39 PM, Artyom Tarasenko atar4q...@googlemail.com wrote: Don't raise irq when not enabled. Raise irq on enabling if DMA_INTR is set Don't clear irq unless it was raised by DMA, as there are other irq sources Don't set DMA_INTR bit spuriously.

[Qemu-devel] Re: sparc32 fix spurious dma interrupts

2010-02-12 Thread Artyom Tarasenko
2010/2/10 Artyom Tarasenko atar4q...@googlemail.com: Don't raise interrupt when not enabled. Don't set DMA_INTR bit spuriously. Don't print misleading debug messages Raise IRQ when not raising any. Haven't noticed that these were introduced recently. Shall we revert

[Qemu-devel] Re: sparc32 fix spurious dma interrupts

2010-02-12 Thread Blue Swirl
On Thu, Feb 11, 2010 at 12:40 AM, Artyom Tarasenko atar4q...@googlemail.com wrote: Don't raise interrupt when not enabled. Don't set DMA_INTR bit spuriously. Don't print misleading debug messages Raise IRQ when not raising any. This breaks most of my Linux tests. *BSD are unaffected. For

[Qemu-devel] Re: sparc32 fix spurious dma interrupts

2010-02-12 Thread Artyom Tarasenko
2010/2/12 Blue Swirl blauwir...@gmail.com: On Thu, Feb 11, 2010 at 12:40 AM, Artyom Tarasenko atar4q...@googlemail.com wrote: Don't raise interrupt when not enabled. Don't set DMA_INTR bit spuriously. Don't print misleading debug messages Raise IRQ when not raising any. This breaks most of

[Qemu-devel] Re: sparc32 fix spurious dma interrupts

2010-02-12 Thread Blue Swirl
On Sat, Feb 13, 2010 at 12:32 AM, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/2/12 Blue Swirl blauwir...@gmail.com: On Thu, Feb 11, 2010 at 12:40 AM, Artyom Tarasenko atar4q...@googlemail.com wrote: Don't raise interrupt when not enabled. Don't set DMA_INTR bit spuriously. Don't