[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)

2009-11-23 Thread Michael S. Tsirkin
On Thu, Nov 19, 2009 at 09:19:05AM -0600, Adam Litke wrote: Rusty and Anthony, If I've addressed all outstanding issues, please consider this patch for inclusion. Thanks. Changes since V2: - Increase stat field size to 64 bits - Report all sizes in kb (not pages) - Drop anon_pages

Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)

2009-11-23 Thread Dor Laor
On 11/23/2009 11:44 AM, Michael S. Tsirkin wrote: On Thu, Nov 19, 2009 at 09:19:05AM -0600, Adam Litke wrote: Rusty and Anthony, If I've addressed all outstanding issues, please consider this patch for inclusion. Thanks. Changes since V2: - Increase stat field size to 64 bits - Report all

Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)

2009-11-23 Thread Vadim Rozenfeld
On 11/23/2009 01:00 PM, Dor Laor wrote: On 11/23/2009 11:44 AM, Michael S. Tsirkin wrote: On Thu, Nov 19, 2009 at 09:19:05AM -0600, Adam Litke wrote: Rusty and Anthony, If I've addressed all outstanding issues, please consider this patch for inclusion. Thanks. Changes since V2: -

[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)

2009-11-19 Thread Avi Kivity
On 11/19/2009 05:19 PM, Adam Litke wrote: Rusty and Anthony, If I've addressed all outstanding issues, please consider this patch for inclusion. Thanks. +struct virtio_balloon_stat +{ + __le16 tag; + __le64 val; +}; + You're not doing endian conversion in the host? -- error

[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)

2009-11-19 Thread Adam Litke
On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote: On 11/19/2009 05:19 PM, Adam Litke wrote: Rusty and Anthony, If I've addressed all outstanding issues, please consider this patch for inclusion. Thanks. +struct virtio_balloon_stat +{ + __le16 tag; + __le64 val; +}; +

[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)

2009-11-19 Thread Avi Kivity
On 11/19/2009 05:58 PM, Adam Litke wrote: On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote: On 11/19/2009 05:19 PM, Adam Litke wrote: Rusty and Anthony, If I've addressed all outstanding issues, please consider this patch for inclusion. Thanks. +struct virtio_balloon_stat +{ +

[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)

2009-11-19 Thread Adam Litke
On Thu, 2009-11-19 at 18:13 +0200, Avi Kivity wrote: On 11/19/2009 05:58 PM, Adam Litke wrote: On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote: On 11/19/2009 05:19 PM, Adam Litke wrote: Rusty and Anthony, If I've addressed all outstanding issues, please consider this

[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)

2009-11-19 Thread Rusty Russell
On Fri, 20 Nov 2009 01:49:05 am Adam Litke wrote: Rusty and Anthony, If I've addressed all outstanding issues, please consider this patch for inclusion. Thanks. Changes since V2: - Increase stat field size to 64 bits - Report all sizes in kb (not pages) Hi Adam, Looks like we're