[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V6)

2010-01-13 Thread Luiz Capitulino
On Mon, 11 Jan 2010 13:09:35 -0600 Adam Litke a...@us.ibm.com wrote: After some good discussion, V6 of this patch integrates well with the new QMP support. When the monitor is in QMP mode, the query-balloon command triggers a stats refresh request to the guest. This request is

[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V6)

2010-01-13 Thread Adam Litke
On Wed, 2010-01-13 at 16:04 -0200, Luiz Capitulino wrote: I've tried to apply this patch to play with it, but turns out it conflicts with recent changes in hw/virtio-balloon. Ahh, I will continue my never-ending quest to stay current :) Some comments on the QMP side of the patch follows.

[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V6)

2010-01-13 Thread Luiz Capitulino
On Wed, 13 Jan 2010 12:59:25 -0600 Adam Litke a...@us.ibm.com wrote: +/* + * complete_stats_request - Clean up and report statistics. + */ +static void complete_stats_request(VirtIOBalloon *vb) +{ +QObject *stats = get_stats_qobject(vb); + +if