Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-29 Thread Cornelia Huck
On Wed, 29 Jun 2016 09:41:50 +0800 Jason Wang wrote: > On 2016年06月27日 17:44, Peter Lieven wrote: > > Hi, with the above patch applied: > > > > commit 9f06e71a567ba5ee8b727e65a2d5347fd331d2aa > > Author: Cornelia Huck > > Date: Fri Jun 10 11:04:12 2016 +0200 > > > > virtio-pci: convert to

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-29 Thread Cornelia Huck
On Wed, 29 Jun 2016 16:21:07 +0800 Jason Wang wrote: > > > On 2016年06月29日 15:23, Cornelia Huck wrote: > > On Wed, 29 Jun 2016 09:41:50 +0800 > > Jason Wang wrote: > > > >> > >> On 2016年06月27日 17:44, Peter Lieven wrote: > >>> Hi, with the above patch applied: > >>> > >>> commit 9f06e71a567ba5ee

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-29 Thread Jason Wang
On 2016年06月29日 15:23, Cornelia Huck wrote: On Wed, 29 Jun 2016 09:41:50 +0800 Jason Wang wrote: On 2016年06月27日 17:44, Peter Lieven wrote: Hi, with the above patch applied: commit 9f06e71a567ba5ee8b727e65a2d5347fd331d2aa Author: Cornelia Huck Date: Fri Jun 10 11:04:12 2016 +0200 v

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-29 Thread Cornelia Huck
On Wed, 29 Jun 2016 09:41:50 +0800 Jason Wang wrote: > > > On 2016年06月27日 17:44, Peter Lieven wrote: > > Hi, with the above patch applied: > > > > commit 9f06e71a567ba5ee8b727e65a2d5347fd331d2aa > > Author: Cornelia Huck > > Date: Fri Jun 10 11:04:12 2016 +0200 > > > > virtio-pci: conver

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-28 Thread Jason Wang
On 2016年06月27日 17:44, Peter Lieven wrote: Hi, with the above patch applied: commit 9f06e71a567ba5ee8b727e65a2d5347fd331d2aa Author: Cornelia Huck Date: Fri Jun 10 11:04:12 2016 +0200 virtio-pci: convert to ioeventfd callbacks a Ubuntu 14.04 VM freezes at startup when blk-mq is set up

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-28 Thread Peter Lieven
Am 28.06.2016 um 10:16 schrieb Cornelia Huck: On Tue, 28 Jun 2016 09:47:01 +0200 Peter Lieven wrote: The problem goes away, but its horribly slow. Maybe the lost notifications you were thinking off. I have the following patch (works for me on ccw as well). I'm worried about the slowness you'r

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-28 Thread Cornelia Huck
On Tue, 28 Jun 2016 09:47:01 +0200 Peter Lieven wrote: > The problem goes away, but its horribly slow. Maybe the lost notifications > you were thinking off. I have the following patch (works for me on ccw as well). I'm worried about the slowness you're seeing, though. Is this just with an iscsi

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-28 Thread Cornelia Huck
On Tue, 28 Jun 2016 09:47:01 +0200 Peter Lieven wrote: > Am 28.06.2016 um 09:42 schrieb Cornelia Huck: > > On Tue, 28 Jun 2016 10:03:21 +0300 > > "Michael S. Tsirkin" wrote: > > > >> I notice cleanup is a bit weird: > >> > >> virtio_queue_set_host_notifier_fd_handler(vq, false, false);

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-28 Thread Peter Lieven
Am 28.06.2016 um 09:42 schrieb Cornelia Huck: On Tue, 28 Jun 2016 10:03:21 +0300 "Michael S. Tsirkin" wrote: I notice cleanup is a bit weird: virtio_queue_set_host_notifier_fd_handler(vq, false, false); k->ioeventfd_assign(proxy, notifier, n, assign); event_notifier

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-28 Thread Cornelia Huck
On Tue, 28 Jun 2016 10:03:21 +0300 "Michael S. Tsirkin" wrote: > I notice cleanup is a bit weird: > > virtio_queue_set_host_notifier_fd_handler(vq, false, false); > k->ioeventfd_assign(proxy, notifier, n, assign); > event_notifier_cleanup(notifier); > > I think virtio_qu

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-28 Thread Cornelia Huck
On Tue, 28 Jun 2016 08:22:05 +0200 Peter Lieven wrote: > Am 27.06.2016 um 17:09 schrieb Cornelia Huck: > > On Mon, 27 Jun 2016 11:44:47 +0200 > > Peter Lieven wrote: > > > >> Hi, with the above patch applied: > >> > >> commit 9f06e71a567ba5ee8b727e65a2d5347fd331d2aa > >> Author: Cornelia Huck >

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-28 Thread Michael S. Tsirkin
On Mon, Jun 27, 2016 at 05:09:38PM +0200, Cornelia Huck wrote: > On Mon, 27 Jun 2016 11:44:47 +0200 > Peter Lieven wrote: > > > Hi, with the above patch applied: > > > > commit 9f06e71a567ba5ee8b727e65a2d5347fd331d2aa > > Author: Cornelia Huck > > Date: Fri Jun 10 11:04:12 2016 +0200 > > > >

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-27 Thread Peter Lieven
Am 27.06.2016 um 17:09 schrieb Cornelia Huck: On Mon, 27 Jun 2016 11:44:47 +0200 Peter Lieven wrote: Hi, with the above patch applied: commit 9f06e71a567ba5ee8b727e65a2d5347fd331d2aa Author: Cornelia Huck Date: Fri Jun 10 11:04:12 2016 +0200 virtio-pci: convert to ioeventfd callback

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-27 Thread Cornelia Huck
On Mon, 27 Jun 2016 11:44:47 +0200 Peter Lieven wrote: > Hi, with the above patch applied: > > commit 9f06e71a567ba5ee8b727e65a2d5347fd331d2aa > Author: Cornelia Huck > Date: Fri Jun 10 11:04:12 2016 +0200 > > virtio-pci: convert to ioeventfd callbacks > > a Ubuntu 14.04 VM freezes at

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-27 Thread Cornelia Huck
On Mon, 27 Jun 2016 11:44:47 +0200 Peter Lieven wrote: > Hi, with the above patch applied: > > commit 9f06e71a567ba5ee8b727e65a2d5347fd331d2aa > Author: Cornelia Huck > Date: Fri Jun 10 11:04:12 2016 +0200 > > virtio-pci: convert to ioeventfd callbacks > > a Ubuntu 14.04 VM freezes at

[Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-27 Thread Peter Lieven
Hi, with the above patch applied: commit 9f06e71a567ba5ee8b727e65a2d5347fd331d2aa Author: Cornelia Huck Date: Fri Jun 10 11:04:12 2016 +0200 virtio-pci: convert to ioeventfd callbacks a Ubuntu 14.04 VM freezes at startup when blk-mq is set up - even if there is only one queue. Peter