Re: [Qemu-devel] Removal of some target CPU macros

2007-11-09 Thread J. Mayer
On Wed, 2007-11-07 at 23:37 +, Paul Brook wrote: I can check the hypervisor feature is not present, for emulating PowerPC 620 on a target that would have hypervisor emulation support. But I cannot do as if the CPU do not have the feature if it's actually available. The PowerPC 64

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-08 Thread Tristan Gingold
Two side comments: Note that most (all ?) embedded Freescale PowerPC microcontrollers implement those extensions and that some ones are greatly interrested with having an usable emulation avaible for those CPUs. Has anyone started to implement spe ? - someone provide an open-source

[Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Fabrice Bellard
I noticed that some target CPUs macros have been added while they do not seem necessary. I don't like that because it introduces more #ifdefs which prevent making a version supporting simultaneously all the CPUs. In particular I saw the following: - TARGET_MIPSN32 : it is always combined with

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Jocelyn Mayer
On Wed, 2007-11-07 at 19:32 +0100, Fabrice Bellard wrote: I noticed that some target CPUs macros have been added while they do not seem necessary. I don't like that because it introduces more #ifdefs which prevent making a version supporting simultaneously all the CPUs. In particular I saw

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Fabrice Bellard
Jocelyn Mayer wrote: On Wed, 2007-11-07 at 19:32 +0100, Fabrice Bellard wrote: I noticed that some target CPUs macros have been added while they do not seem necessary. I don't like that because it introduces more #ifdefs which prevent making a version supporting simultaneously all the CPUs.

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread J. Mayer
On Wed, 2007-11-07 at 22:55 +0100, Fabrice Bellard wrote: Jocelyn Mayer wrote: On Wed, 2007-11-07 at 19:32 +0100, Fabrice Bellard wrote: I noticed that some target CPUs macros have been added while they do not seem necessary. I don't like that because it introduces more #ifdefs which

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Fabrice Bellard
J. Mayer wrote: On Wed, 2007-11-07 at 22:55 +0100, Fabrice Bellard wrote: Jocelyn Mayer wrote: On Wed, 2007-11-07 at 19:32 +0100, Fabrice Bellard wrote: I noticed that some target CPUs macros have been added while they do not seem necessary. I don't like that because it introduces more

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread J. Mayer
On Wed, 2007-11-07 at 22:47 +, Paul Brook wrote: Removing the ppc64h target means, for me, removing any option to emulate the hypervisor feature at any time (if removed) or removing the ability to use the PowerPC 64 targets the way they are when booting on Apple G5 machines (if merged

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Thiemo Seufer
Fabrice Bellard wrote: I noticed that some target CPUs macros have been added while they do not seem necessary. I don't like that because it introduces more #ifdefs which prevent making a version supporting simultaneously all the CPUs. In particular I saw the following: - TARGET_MIPSN32 :

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Bernhard Fischer
On Wed, Nov 07, 2007 at 11:55:26PM +0100, Fabrice Bellard wrote: Why not adding a new CPU type such as PPC970 with hypervisor and keep the current PPC970 implementation as it is without the hypervisor mode. I don't see the problem in replacing the ifdefs with a new CPU model ! You cannot

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Paul Brook
On Wednesday 07 November 2007, Bernhard Fischer wrote: On Wed, Nov 07, 2007 at 11:55:26PM +0100, Fabrice Bellard wrote: Why not adding a new CPU type such as PPC970 with hypervisor and keep the current PPC970 implementation as it is without the hypervisor mode. I don't see the problem in

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Paul Brook
I can check the hypervisor feature is not present, for emulating PowerPC 620 on a target that would have hypervisor emulation support. But I cannot do as if the CPU do not have the feature if it's actually available. The PowerPC 64 target emulates PowerPC 64 without the hypervisor feature,