Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-12 Thread Gerd Hoffmann
Hi, I think we should not generate a type0 table unless -smbios type0=... is explicitly specified on the qemu command line. It is about the firmware, and we should leave it to the firmware to fill it by default. If you are running OVMF (EFI) instead of SeaBIOS you should see it in

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-11 Thread Gerd Hoffmann
Hi, On Thu, Mar 06, 2014 at 10:03:32AM +0100, Gerd Hoffmann wrote: So, if we manage to get the patches into shape in time for qemu 2.0 your way to do that is fine. We are pretty close to the 2.0 freeze though, so maybe we should better plan for post-2.0 anyway, especially as you plan

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-11 Thread Kevin O'Connor
On Tue, Mar 11, 2014 at 11:03:06AM +0100, Gerd Hoffmann wrote: Issue #3: Running a diff on the dmidecode output with and without the patches yields this: I think it would be best to get the patch series to the point that there is no diff between old and new. That will make review easier, and

[Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Gabriel L. Somlo
Hi, This patch set builds full smbios tables in QEMU, and sends them to the bios via fw_cfg as SMBIOS_TABLE_ENTRY blobs. I'm resending these without the In-Reply-To line to avoid having them getting buried under a bunch of other email, per Stefan's suggestion in an unrelated thread. Also cc-ing

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Eric Blake
On 03/10/2014 10:56 AM, Gabriel L. Somlo wrote: Hi, This patch set builds full smbios tables in QEMU, and sends them to the bios via fw_cfg as SMBIOS_TABLE_ENTRY blobs. I'm resending these without the In-Reply-To line to avoid having them getting buried under a bunch of other email, per

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Gabriel L. Somlo
On Mon, Mar 10, 2014 at 11:55:13AM -0600, Eric Blake wrote: On 03/10/2014 10:56 AM, Gabriel L. Somlo wrote: Not quite right. The cover letter should not have In-Reply-To, but the remaining patches SHOULD be in-reply-to the cover letter. That is, you don't want to create 11 top-level

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Gabriel L. Somlo
On Mon, Mar 10, 2014 at 02:17:25PM -0400, Gabriel L. Somlo wrote: 'qemu send-email -10 --annotate --cover-letter' defaults to the proper threading, along with letting you modify your cover letter in your editor before actually sending. That sounds awesome, but there's no send-email script

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Eric Blake
On 03/10/2014 12:17 PM, Gabriel L. Somlo wrote: but instead create 1 top-level thread with all patches under the cover letter: 0/10 |- 1/10 |- 2/10 ... |- 10/10 OK, so I screwed up, now what ? Should I re-send the 10 patches in-reply-to the existing cover letter, or leave it be for now

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Eric Blake
On 03/10/2014 11:55 AM, Eric Blake wrote: On 03/10/2014 10:56 AM, Gabriel L. Somlo wrote: Hi, This patch set builds full smbios tables in QEMU, and sends them to the bios via fw_cfg as SMBIOS_TABLE_ENTRY blobs. 'qemu send-email -10 --annotate --cover-letter' defaults to the proper

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Eric Blake
On 03/10/2014 01:14 PM, Eric Blake wrote: Upstream git.git has included send-email for years; but many distros ship it as a separate package because of the additional dependencies it drags in. On Fedora systems, it is part of the 'git-email' package. Hmm - something to add to the SubmitAPatch