Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Avi Kivity
On 03/18/2012 02:08 PM, Avi Kivity wrote: > > > > Screen is not updated correctly, there are lines from previous > > screenful. Pressing ctrl-alt-1 refreshes the display. Perhaps dirty > > tracking is broken? VGA in x86 works. > > Ok, I see it. Will investigate. > Turns out it's a latent bug in q

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 12:13, Avi Kivity wrote: > On 03/18/2012 02:10 PM, Blue Swirl wrote: >> On Sun, Mar 18, 2012 at 12:08, Avi Kivity wrote: >> > On 03/18/2012 12:51 PM, Blue Swirl wrote: >> >> > >> >> > IMO, my patch is better.  tlb_set_page() should not deal with offsets >> >> > within a pa

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Avi Kivity
On 03/18/2012 02:10 PM, Blue Swirl wrote: > On Sun, Mar 18, 2012 at 12:08, Avi Kivity wrote: > > On 03/18/2012 12:51 PM, Blue Swirl wrote: > >> > > >> > IMO, my patch is better. tlb_set_page() should not deal with offsets > >> > within a page. > >> > >> It looks like all targets except Sparc32/64

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 12:08, Avi Kivity wrote: > On 03/18/2012 12:51 PM, Blue Swirl wrote: >> > >> > IMO, my patch is better.  tlb_set_page() should not deal with offsets >> > within a page. >> >> It looks like all targets except Sparc32/64 mask the addresses before >> passing to tlb_set_page(),

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Avi Kivity
On 03/18/2012 12:51 PM, Blue Swirl wrote: > > > > IMO, my patch is better. tlb_set_page() should not deal with offsets > > within a page. > > It looks like all targets except Sparc32/64 mask the addresses before > passing to tlb_set_page(), so I agree. Ok. Commit my patch then? > > If you prefe

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 11:03, Mark Cave-Ayland wrote: > On 18/03/12 10:51, Blue Swirl wrote: > (except Sparc32, Sparc64 and PPC displays are still not refreshed correctly). >>> >>> >>> Details about this please. >> >> >> Screen is not updated correctly, there are lines from previous >>

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Mark Cave-Ayland
On 18/03/12 10:51, Blue Swirl wrote: (except Sparc32, Sparc64 and PPC displays are still not refreshed correctly). Details about this please. Screen is not updated correctly, there are lines from previous screenful. Pressing ctrl-alt-1 refreshes the display. Perhaps dirty tracking is broken?

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 10:31, Avi Kivity wrote: > On 03/18/2012 11:51 AM, Blue Swirl wrote: >> On Sun, Mar 18, 2012 at 09:44, Avi Kivity wrote: >> > On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: >> >> Hi Avi/Blue, >> >> >> >> I've just updated to git master and found that SPARC64 is broken >>

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Avi Kivity
On 03/18/2012 11:51 AM, Blue Swirl wrote: > On Sun, Mar 18, 2012 at 09:44, Avi Kivity wrote: > > On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: > >> Hi Avi/Blue, > >> > >> I've just updated to git master and found that SPARC64 is broken > >> again; a git bisect shows the following commit causes t

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Mark Cave-Ayland
On 18/03/12 09:44, Avi Kivity wrote: Hi Avi/Blue, I've just updated to git master and found that SPARC64 is broken again; a git bisect shows the following commit causes this: commit f3705d53296d78b14f5823472ae2add16a25a0a5 Author: Avi Kivity Date: Thu Mar 8 16:16:34 2012 +0200 memory:

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 09:44, Avi Kivity wrote: > On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: >> Hi Avi/Blue, >> >> I've just updated to git master and found that SPARC64 is broken >> again; a git bisect shows the following commit causes this: >> >> >> commit f3705d53296d78b14f5823472ae2add16

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 09:44, Avi Kivity wrote: > On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: >> Hi Avi/Blue, >> >> I've just updated to git master and found that SPARC64 is broken >> again; a git bisect shows the following commit causes this: >> >> >> commit f3705d53296d78b14f5823472ae2add16

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Avi Kivity
On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: > Hi Avi/Blue, > > I've just updated to git master and found that SPARC64 is broken > again; a git bisect shows the following commit causes this: > > > commit f3705d53296d78b14f5823472ae2add16a25a0a5 > Author: Avi Kivity > Date: Thu Mar 8 16:16:34

[Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-17 Thread Mark Cave-Ayland
Hi Avi/Blue, I've just updated to git master and found that SPARC64 is broken again; a git bisect shows the following commit causes this: commit f3705d53296d78b14f5823472ae2add16a25a0a5 Author: Avi Kivity Date: Thu Mar 8 16:16:34 2012 +0200 memory: make phys_page_find() return an unad