Re: [Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-13 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: Hi, I wanted to start a central thread as this discussion is spread in two places right now. I think I'm becoming convinced that realized belongs in DeviceState and that BlockDriverState does not have a realized equivalent. To me, realized

Re: [Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-13 Thread Paolo Bonzini
Il 13/06/2012 14:53, Markus Armbruster ha scritto: This behavior is necessary to allow overriding backing files. Could you explain why we need to override backing files between open and attach? Open tells us that you need a backing file. After attach, state should be finalized. Hence,

Re: [Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-13 Thread Anthony Liguori
On 06/13/2012 07:53 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: Hi, I wanted to start a central thread as this discussion is spread in two places right now. I think I'm becoming convinced that realized belongs in DeviceState and that BlockDriverState does not

Re: [Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-13 Thread Kevin Wolf
Am 13.06.2012 14:53, schrieb Markus Armbruster: Anthony Liguori anth...@codemonkey.ws writes: Properties that affect file opening (flags and filename) cannot be changed after this point. Depending on the contents of the file, a backing_file property may be created after opened = true. The

Re: [Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-12 Thread Paolo Bonzini
Il 12/06/2012 00:05, Anthony Liguori ha scritto: opened = true attached = true This means that the device is in-use by something in QEMU. Requests may be in flight as read/write requests are now allowed to be issued. Most properties cannot be changed in this state (presumably). So

Re: [Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-12 Thread Kevin Wolf
Am 12.06.2012 00:05, schrieb Anthony Liguori: To me, realized represents Vcc. When realized=true, the guest has power and is active. When realized=false, the guest has lost power. The realize() event is the rising edge of Vcc, unrealized() is the falling edge. realize() should be

Re: [Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-12 Thread Kevin Wolf
Am 12.06.2012 08:10, schrieb Paolo Bonzini: Il 12/06/2012 00:05, Anthony Liguori ha scritto: opened = true attached = true This means that the device is in-use by something in QEMU. Requests may be in flight as read/write requests are now allowed to be issued. Most properties cannot be

[Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-11 Thread Anthony Liguori
Hi, I wanted to start a central thread as this discussion is spread in two places right now. I think I'm becoming convinced that realized belongs in DeviceState and that BlockDriverState does not have a realized equivalent. To me, realized represents Vcc. When realized=true, the guest has

Re: [Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-11 Thread Andreas Färber
Am 12.06.2012 00:05, schrieb Anthony Liguori: I think I'm becoming convinced that realized belongs in DeviceState and that BlockDriverState does not have a realized equivalent. To me, realized represents Vcc. When realized=true, the guest has power and is active. When realized=false, the

Re: [Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-11 Thread Anthony Liguori
On 06/11/2012 07:29 PM, Andreas Färber wrote: Am 12.06.2012 00:05, schrieb Anthony Liguori: I think I'm becoming convinced that realized belongs in DeviceState and that BlockDriverState does not have a realized equivalent. To me, realized represents Vcc. When realized=true, the guest has