[Qemu-devel] Some patch about mips, gen_HILO bug fix.

2012-12-10 Thread Elta Era
Hi all, I make three patch about mips 1: Fix my email address in dsp_helper.c 2: Fix repl_ph, value should sign-extend to target_long 3: Fix gen_HILO, there is a bug when we use dsp arch, at that time acc index will be 0-3, and mipsdsp already add in. mipsdsp just take acc index from opcode, on

Re: [Qemu-devel] Some patch about mips, gen_HILO bug fix.

2012-12-10 Thread Wei-Ren Chen
Hi, 1: Fix my email address in dsp_helper.c 2: Fix repl_ph, value should sign-extend to target_long 3: Fix gen_HILO, there is a bug when we use dsp arch, at that time acc index will be 0-3, and mipsdsp already add in. mipsdsp just take acc index from opcode, on other arch, it my bring a

Re: [Qemu-devel] Some patch about mips, gen_HILO bug fix.

2012-12-10 Thread Jovanovic, Petar
0002-Make-repl_ph-to-sign-extended-to-target_long.patch 0003-Fix-gen_HILO-to-make-it-adapt-each-arch-which-use-ac.patch Can you send examples/tests for the issues that you fix? It makes easier to review if you provide a simple example of a failing test. Petar

Re: [Qemu-devel] Some patch about mips, gen_HILO bug fix.

2012-12-10 Thread Richard Henderson
On 12/10/2012 12:37 AM, Elta Era wrote: tcg_gen_movi_tl(cpu_gpr[ret], \ -(target_long)((int32_t)imm 16 | \ +(target_long)(int32_t)((int32_t)imm 16 | \ (uint32_t)(uint16_t)imm));