Re: [Qemu-devel] Suspicious code in qcow2.

2011-09-08 Thread Kevin Wolf
Am 07.09.2011 18:42, schrieb Frediano Ziglio: > Actually it does not cause problems but this code order seems a bit > wrong to me (block/qcow2-cluster.c) > > > QLIST_INSERT_HEAD(&s->cluster_allocs, m, next_in_flight); > > /* allocate a new cluster */ > > cluster_offset = qcow2_alloc

[Qemu-devel] Suspicious code in qcow2.

2011-09-07 Thread Frediano Ziglio
Actually it does not cause problems but this code order seems a bit wrong to me (block/qcow2-cluster.c) QLIST_INSERT_HEAD(&s->cluster_allocs, m, next_in_flight); /* allocate a new cluster */ cluster_offset = qcow2_alloc_clusters(bs, nb_clusters * s->cluster_size); if (cluster_of