Re: [Qemu-devel] Unaligned images with O_DIRECT

2019-05-14 Thread Eric Blake
On 5/14/19 12:28 PM, Max Reitz wrote: >>> >>> The tail of an unaligned file is generally inaccessible to O_DIRECT, >> >> Especially with this. >> >>> where it is easier to use ftruncate() up to an aligned boundary if you >>> really must play with that region of the file, and then ftruncate() back

Re: [Qemu-devel] Unaligned images with O_DIRECT

2019-05-14 Thread Max Reitz
On 14.05.19 18:15, Max Reitz wrote: > On 14.05.19 17:45, Eric Blake wrote: >> On 5/14/19 10:06 AM, Max Reitz wrote: >>> Hi, >>> >>> Unaligned images don’t work so well with O_DIRECT: >>> >>> $ echo > foo >>> $ qemu-img map --image-opts driver=file,filename=foo,cache.direct=on >>> Offset

Re: [Qemu-devel] Unaligned images with O_DIRECT

2019-05-14 Thread Max Reitz
On 14.05.19 17:45, Eric Blake wrote: > On 5/14/19 10:06 AM, Max Reitz wrote: >> Hi, >> >> Unaligned images don’t work so well with O_DIRECT: >> >> $ echo > foo >> $ qemu-img map --image-opts driver=file,filename=foo,cache.direct=on >> Offset Length Mapped to File >>

Re: [Qemu-devel] Unaligned images with O_DIRECT

2019-05-14 Thread Eric Blake
On 5/14/19 10:06 AM, Max Reitz wrote: > Hi, > > Unaligned images don’t work so well with O_DIRECT: > > $ echo > foo > $ qemu-img map --image-opts driver=file,filename=foo,cache.direct=on > Offset Length Mapped to File > qemu-img: block/io.c:2093: bdrv_co_block_status:

[Qemu-devel] Unaligned images with O_DIRECT

2019-05-14 Thread Max Reitz
Hi, Unaligned images don’t work so well with O_DIRECT: $ echo > foo $ qemu-img map --image-opts driver=file,filename=foo,cache.direct=on Offset Length Mapped to File qemu-img: block/io.c:2093: bdrv_co_block_status: Assertion `*pnum && QEMU_IS_ALIGNED(*pnum, align) &&