[Qemu-devel] a newbie question: code patches

2011-08-05 Thread cheetah
Hi folks, I need to do some changes to qemu-kvm. However, on the kvm website, it is suggested to develop against qemu.git. I am wondering if I develop against qemu.git, because my fix may depend on some new patch that is only in qemu.git, it seems very hard to generate a patch for the qemu-kvm.

Re: [Qemu-devel] a newbie question: code patches

2011-08-05 Thread Stefan Hajnoczi
On Fri, Aug 5, 2011 at 9:56 AM, cheetah xuw...@gmail.com wrote: I need to do some changes to qemu-kvm. However, on the kvm website, it is suggested to develop against qemu.git. I am wondering if I develop against qemu.git, because my fix may depend on some new patch that is only in qemu.git,

Re: [Qemu-devel] a newbie question: code patches

2011-08-05 Thread cheetah
Thanks for the quickly reply. I am going to change/add the block driver and some image format code. If I develop against the qemu.git, can I easily generate a patch to apply to qemu-kvm.git too? Do you have some best practices to recommend? ;) Thanks! Regards, Peter On Fri, Aug 5, 2011 at 2:00

Re: [Qemu-devel] a newbie question: code patches

2011-08-05 Thread Paolo Bonzini
On 08/05/2011 11:04 AM, cheetah wrote: Thanks for the quickly reply. I am going to change/add the block driver and some image format code. If I develop against the qemu.git, can I easily generate a patch to apply to qemu-kvm.git too? Yes, or vice versa too. You can develop against

Re: [Qemu-devel] a newbie question: code patches

2011-08-05 Thread cheetah
Sounds great. Thanks. I am a newbie and still confusing on how to do it. Please excuse my ignorance. If I forked a my own branch on qemu.git and develop against it. For instance I change qcow2.c which depends on some functions in block.c which are different from qemu-kvm.git because qemu-kvm.git

Re: [Qemu-devel] a newbie question: code patches

2011-08-05 Thread Stefan Hajnoczi
On Fri, Aug 5, 2011 at 10:19 AM, cheetah xuw...@gmail.com wrote: Sounds great. Thanks. I am a newbie and still confusing on how to do it. Please excuse my ignorance. If I forked a my own branch on qemu.git and develop against it. For instance I change qcow2.c which depends on some functions

Re: [Qemu-devel] a newbie question: code patches

2011-08-05 Thread cheetah
Thanks for the advice. I will formalize my plan and send to the maillist. Peter On Fri, Aug 5, 2011 at 2:33 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Aug 5, 2011 at 10:19 AM, cheetah xuw...@gmail.com wrote: Sounds great. Thanks. I am a newbie and still confusing on how to do