Re: [Qemu-devel] dump-guest-memory enhancement.

2013-11-12 Thread Dave Anderson
- Original Message - > I haven't been there at the original creation of this functionality, but > I tend to agree with you. For analyzing the vmcore with gdb or crash, > the alignment doesn't seem to be important, so it was probably ignored. With respect to the crash utility, the p_alig

Re: [Qemu-devel] dump-guest-memory enhancement.

2013-11-11 Thread Peter Maydell
On 11 November 2013 03:28, Phi Debian wrote: > The Align fot the PT_LOAD is ZERO, then the offset is 0x114, having an > Align set to TARGET_PAGE_BITS, (or at least 4Kb) would provide a > chance for any debugger to do page align copy (either lseek/read, or > mmap) as they trip on the core, marginal

Re: [Qemu-devel] dump-guest-memory enhancement.

2013-11-11 Thread Phi Debian
Hi Laszlo, On Mon, Nov 11, 2013 at 8:38 PM, Laszlo Ersek wrote: > > But first, I think you meant TARGET_PAGE_SIZE, not TARGET_PAGE_BITS, for > the p_align field. > > So, the specs say for p_align: > >> As ``Program Loading'' describes in this chapter of the processor >> supplement, loadable pro

Re: [Qemu-devel] dump-guest-memory enhancement.

2013-11-11 Thread Laszlo Ersek
On 11/11/13 04:28, Phi Debian wrote: > CU82$ /usr/bin/readelf -a vmcore > Program Headers: > Type Offset VirtAddrPhysAddr FileSizMemSiz Flg Align > NOTE 0x74 0x 0x 0x000a0 0x000a0 0 > LOAD 0x000114 0x6000 0x6000 0x4000 0x40

Re: [Qemu-devel] dump-guest-memory enhancement.

2013-11-10 Thread Phi Debian
Hi All, Sorry Laszlo for flooding your mailbox, I missed the 'reply to all' so I redo the post here. And I added some more comment at the end to answer your questions. Phi == CU82$ /usr/bin/readelf -a vmcore ELF Header: Magic: 7f 45 4c

Re: [Qemu-devel] dump-guest-memory enhancement.

2013-11-10 Thread Laszlo Ersek
On 11/10/13 10:10, Phi Debian wrote: > Hi All, > > I implemented guest-dump-memory for arm32, and bumped in something > strange, the PT_LOADs generated from dump.c are not target page > aligned. There are some advantage to get PT_LOAD aligned. > > This mail is to ask advise about patch I could su

[Qemu-devel] dump-guest-memory enhancement.

2013-11-10 Thread Phi Debian
Hi All, I implemented guest-dump-memory for arm32, and bumped in something strange, the PT_LOADs generated from dump.c are not target page aligned. There are some advantage to get PT_LOAD aligned. This mail is to ask advise about patch I could submit later if wanted. Would it be desirable to get