Re: [Qemu-devel] e1000 patch for osx

2013-10-31 Thread jacek burghardt
I will test this with 10.8.3

Re: [Qemu-devel] e1000 patch for osx

2013-10-31 Thread Gabriel L. Somlo
On Wed, Oct 30, 2013 at 6:31 PM, jacek burghardt wrote: > I got this error > hw/net/e1000.c: In function 'set_phy_ctrl': > hw/net/e1000.c:209:10: warning: implicit declaration of function 'set_ics' > [-Wimplicit-function-declaration] That's because set_ics needs to be declared before being used in

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread jacek burghardt
I got this error hw/net/e1000.c: In function 'set_phy_ctrl': hw/net/e1000.c:209:10: warning: implicit declaration of function 'set_ics' [-Wimplicit-function-declaration] set_ics(s, 0, E1000_ICR_LSC); ^ hw/net/e1000.c:209:10: warning: nested extern declaration of 'set_ics' [-Wnes

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread jacek burghardt
I will try that the original patch: --- qemu-kvm-0.12.5/hw/e1000.c.vanilla 2011-02-19 12:28:38.0 + +++ qemu-kvm-0.12.5/hw/e1000.c 2011-02-21 14:11:33.0 + @@ -199,6 +202,8 @@ { /* RST is self clearing */ s->mac_reg[CTRL] = val & ~E1000_CTRL_RST; +if (val & E1

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread Paolo Bonzini
Il 31/10/2013 01:21, jacek burghardt ha scritto: > I am in process of recompiling qemu right now > I came up with this patch is this correct > diff -Naur qemu/hw/net/e1000.c qemu-a/hw/net/e1000.c > --- qemu/hw/net/e1000.c 2013-10-27 15:36:05.496526538 -0600 > +++ qemu-a/hw/net/e1000.c 2013-1

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread jacek burghardt
i got this error hw/net/e1000.c: In function 'set_phy_ctrl': hw/net/e1000.c:209:10: warning: implicit declaration of function 'set_ics' [-Wimplicit-function-declaration] set_ics(s, 0, E1000_ICR_LSC); ^ hw/net/e1000.c:209:10: warning: nested extern declaration of 'set_ics' [-Wnes

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread jacek burghardt
I am in process of recompiling qemu right now I came up with this patch is this correct diff -Naur qemu/hw/net/e1000.c qemu-a/hw/net/e1000.c --- qemu/hw/net/e1000.c 2013-10-27 15:36:05.496526538 -0600 +++ qemu-a/hw/net/e1000.c 2013-10-30 18:09:03.101711694 -0600 @@ -203,6 +203,12 @@

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread Paolo Bonzini
Il 31/10/2013 00:54, jacek burghardt ha scritto: > I wonder if anyone can post reworked patch to latest qemu That's what I did 5 hours ago, though what I did was actually to look at the bits affected by the patch and reimplement them based on the e1000 hardware spec. Can you test the second pat

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread jacek burghardt
I wonder if anyone can post reworked patch to latest qemu On Fri, Oct 25, 2013 at 8:27 AM, jacek burghardt wrote: > > https://github.com/saucelabs/mac-osx-on-kvm/blob/master/e1000-mac-hacks.patch > > -} else > -s->phy_reg[addr] = data; > +} else { > +/* s

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread Paolo Bonzini
Il 30/10/2013 18:29, Peter Maydell ha scritto: > This looks odd -- you seem to be modifying val but then not > using the modified value before we reach the end of the function. > >> > } >> > >> > static void >> > @@ -445,8 +450,9 @@ set_mdic(E1000State *s, int index, uint32_t val) >> >

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread jacek burghardt
The function of this patch is initialize emulated network card and pass data just like Mac firmware

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread Peter Maydell
On 30 October 2013 16:52, Paolo Bonzini wrote: > Il 25/10/2013 15:53, jacek burghardt ha scritto: >> Is there a patch for qemu git master that pre init e1000 so I can get >> rid off unpluged network cable message ? I know there is patch but is is >> for older version of qemu and it seeem that it n

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread Paolo Bonzini
Il 25/10/2013 15:53, jacek burghardt ha scritto: > Is there a patch for qemu git master that pre init e1000 so I can get > rid off unpluged network cable message ? I know there is patch but is is > for older version of qemu and it seeem that it no longer functions and > does not apply fully as code

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread Andreas Färber
Am 30.10.2013 14:26, schrieb jacek burghardt: > Well I was hoping anyone could port the patch to qemu it seems the code > changed a lot in one year Problem is that the patch you referenced does not have a Signed-off-by. We can't just rebase and apply it without contacting the author. Some minor n

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread jacek burghardt
Well I was hoping anyone could port the patch to qemu it seems the code changed a lot in one year

Re: [Qemu-devel] e1000 patch for osx

2013-10-30 Thread Stefan Hajnoczi
On Fri, Oct 25, 2013 at 08:27:27AM -0600, jacek burghardt wrote: > https://github.com/saucelabs/mac-osx-on-kvm/blob/master/e1000-mac-hacks.patch > > -} else > -s->phy_reg[addr] = data; > +} else { > +/* some (reset) bits are self clearing, so better clear th

Re: [Qemu-devel] e1000 patch for osx

2013-10-25 Thread jacek burghardt
https://github.com/saucelabs/mac-osx-on-kvm/blob/master/e1000-mac-hacks.patch -} else -s->phy_reg[addr] = data; +} else { +/* some (reset) bits are self clearing, so better clear them */ +switch (addr) { +case PHY_CTRL: +

Re: [Qemu-devel] e1000 patch for osx

2013-10-25 Thread Paolo Bonzini
Il 25/10/2013 14:53, jacek burghardt ha scritto: > Is there a patch for qemu git master that pre init e1000 so I can get > rid off unpluged network cable message ? I know there is patch but is is > for older version of qemu and it seeem that it no longer functions and > does not apply fully as code

[Qemu-devel] e1000 patch for osx

2013-10-25 Thread jacek burghardt
Is there a patch for qemu git master that pre init e1000 so I can get rid off unpluged network cable message ? I know there is patch but is is for older version of qemu and it seeem that it no longer functions and does not apply fully as code was changed.