subject:"\[Qemu\-devel\] hw\/scsi\/megasas.c\: \(sdev\->id \& 0xFF\) >> 8"

Re: [Qemu-devel] hw/scsi/megasas.c: (sdev->id & 0xFF) >> 8

2014-05-16 Thread Markus Armbruster

Ping? Markus Armbruster writes: > There are several instances of > > ((sdev->id & 0xFF) >> 8) | (sdev->lun & 0xFF) > > or similar. The left operand of | is always 0. Did you intend to shift > to the other right?

[Qemu-devel] hw/scsi/megasas.c: (sdev->id & 0xFF) >> 8

2014-01-30 Thread Markus Armbruster

There are several instances of ((sdev->id & 0xFF) >> 8) | (sdev->lun & 0xFF) or similar. The left operand of | is always 0. Did you intend to shift to the other right?