Re: [Qemu-devel] kvm / virsh snapshot management

2019-06-10 Thread Gary Dale
On 2019-06-10 8:10 p.m., Eric Blake wrote: On 6/10/19 6:00 PM, Gary Dale wrote: Any ideas on what I'm doing wrong? Do you know for sure whether you have internal or external snapshots? And at this point, your questions are starting to wander more into libvirt territory. Yes. I'm using

Re: [Qemu-devel] kvm / virsh snapshot management

2019-06-10 Thread Eric Blake
On 6/10/19 6:00 PM, Gary Dale wrote: >>> Any ideas on what I'm doing wrong? >> Do you know for sure whether you have internal or external snapshots? >> And at this point, your questions are starting to wander more into >> libvirt territory. >> > Yes. I'm using internal snapshots. From your other

Re: [Qemu-devel] kvm / virsh snapshot management

2019-06-10 Thread Gary Dale
On 2019-06-10 6:07 p.m., Eric Blake wrote: On 6/10/19 4:27 PM, Gary Dale wrote: Trying this against a test VM, I ran into a roadblock. My command line and the results are: # virsh blockcommit stretch "/home/secure/virtual/stretch.qcow2" --top stretchS3 --delete --wait error: unsupported flags

Re: [Qemu-devel] kvm / virsh snapshot management

2019-06-10 Thread Eric Blake
On 6/10/19 5:47 PM, Gary Dale wrote: >>> >>> Since blockcommit would make it impossible for me to revert to an >>> earlier state (because I'm committing the oldest snapshot, if it screws >>> up, I can't undo within virsh), I need to make sure this command is >>> correct. >>> >>> > Interesting.

Re: [Qemu-devel] kvm / virsh snapshot management

2019-06-10 Thread Gary Dale
On 2019-06-10 6:04 p.m., Eric Blake wrote: On 6/10/19 10:54 AM, Gary Dale wrote: One explanation I've seen of the process is if I delete a snapshot, the changes it contains are merged with its immediate child. Nope.  Deleting a snapshot decrements the reference count on all its data clusters. 

Re: [Qemu-devel] kvm / virsh snapshot management

2019-06-10 Thread Eric Blake
On 6/10/19 4:27 PM, Gary Dale wrote: >> > Trying this against a test VM, I ran into a roadblock. My command line > and the results are: > > # virsh blockcommit stretch "/home/secure/virtual/stretch.qcow2" --top > stretchS3 --delete --wait > error: unsupported flags (0x2) in function

Re: [Qemu-devel] kvm / virsh snapshot management

2019-06-10 Thread Eric Blake
On 6/10/19 10:54 AM, Gary Dale wrote: >>> One explanation I've seen of the process is if I delete a snapshot, the >>> changes it contains are merged with its immediate child. >> Nope.  Deleting a snapshot decrements the reference count on all its >> data clusters.  If a data cluster's reference

Re: [Qemu-devel] kvm / virsh snapshot management

2019-06-10 Thread Gary Dale
On 2019-06-10 11:54 a.m., Gary Dale wrote: On 2019-06-10 8:19 a.m., Stefan Hajnoczi wrote: On Sat, Jun 01, 2019 at 08:12:01PM -0400, Gary Dale wrote: A while back I converted a raw disk image to qcow2 to be able to use snapshots. However I realize that I may not really understand exactly how

Re: [Qemu-devel] kvm / virsh snapshot management

2019-06-10 Thread Gary Dale
On 2019-06-10 8:19 a.m., Stefan Hajnoczi wrote: On Sat, Jun 01, 2019 at 08:12:01PM -0400, Gary Dale wrote: A while back I converted a raw disk image to qcow2 to be able to use snapshots. However I realize that I may not really understand exactly how snapshots work. In this particular case, I'm

Re: [Qemu-devel] kvm / virsh snapshot management

2019-06-10 Thread Stefan Hajnoczi
On Sat, Jun 01, 2019 at 08:12:01PM -0400, Gary Dale wrote: > A while back I converted a raw disk image to qcow2 to be able to use > snapshots. However I realize that I may not really understand exactly how > snapshots work. In this particular case, I'm only talking about internal > snapshots