Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-19 Thread Alexey Kardashevskiy
On 09/18/2014 07:56 PM, Paolo Bonzini wrote: Il 18/09/2014 05:26, Alexey Kardashevskiy ha scritto: On 09/18/2014 01:07 AM, Stefan Hajnoczi wrote: On Wed, Sep 17, 2014 at 2:44 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 09/17/2014 07:25 PM, Paolo Bonzini wrote: btw any better idea of a

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-19 Thread Kevin Wolf
Am 16.09.2014 um 14:59 hat Paolo Bonzini geschrieben: Il 16/09/2014 14:52, Kevin Wolf ha scritto: Yes, that's true. We can't fix this problem in qcow2, though, because it's a more general one. I think we must make sure that bdrv_invalidate_cache() doesn't yield. Either by forbidding

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-18 Thread Paolo Bonzini
Il 18/09/2014 05:26, Alexey Kardashevskiy ha scritto: On 09/18/2014 01:07 AM, Stefan Hajnoczi wrote: On Wed, Sep 17, 2014 at 2:44 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 09/17/2014 07:25 PM, Paolo Bonzini wrote: btw any better idea of a hack to try? Testers are pushing me - they want

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-17 Thread Alexey Kardashevskiy
On 09/16/2014 10:34 PM, Kevin Wolf wrote: Am 16.09.2014 um 14:10 hat Paolo Bonzini geschrieben: Il 16/09/2014 14:02, Alexey Kardashevskiy ha scritto: I am having problems when migrate a guest via libvirt like this: virsh migrate --live --persistent --undefinesource --copy-storage-all

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-17 Thread Stefan Hajnoczi
On Tue, Sep 16, 2014 at 02:10:39PM +0200, Paolo Bonzini wrote: Il 16/09/2014 14:02, Alexey Kardashevskiy ha scritto: I am having problems when migrate a guest via libvirt like this: virsh migrate --live --persistent --undefinesource --copy-storage-all --verbose --desturi

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-17 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: I think the fundamental problem here is that the mirror block job on the source host does not synchronize with live migration. Remember the mirror block job iterates on the dirty bitmap whenever

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-17 Thread Alexey Kardashevskiy
On 09/17/2014 07:25 PM, Paolo Bonzini wrote: Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: I think the fundamental problem here is that the mirror block job on the source host does not synchronize with live migration. Remember the mirror block job iterates on the dirty bitmap whenever

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-17 Thread Stefan Hajnoczi
On Wed, Sep 17, 2014 at 10:25 AM, Paolo Bonzini pbonz...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: I think the fundamental problem here is that the mirror block job on the source host does not synchronize with live

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-17 Thread Stefan Hajnoczi
On Wed, Sep 17, 2014 at 2:44 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 09/17/2014 07:25 PM, Paolo Bonzini wrote: btw any better idea of a hack to try? Testers are pushing me - they want to upgrade the broken setup and I am blocking them :) Thanks! Paolo's qemu_co_mutex_lock(s-lock)

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-17 Thread Eric Blake
[adding libvirt list] On 09/17/2014 09:04 AM, Stefan Hajnoczi wrote: On Wed, Sep 17, 2014 at 10:25 AM, Paolo Bonzini pbonz...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: I think the fundamental problem here is that the

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-17 Thread Paolo Bonzini
Il 17/09/2014 17:04, Stefan Hajnoczi ha scritto: On Wed, Sep 17, 2014 at 10:25 AM, Paolo Bonzini pbonz...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: I think the fundamental problem here is that the mirror block job on the

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-17 Thread Alexey Kardashevskiy
On 09/18/2014 01:07 AM, Stefan Hajnoczi wrote: On Wed, Sep 17, 2014 at 2:44 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 09/17/2014 07:25 PM, Paolo Bonzini wrote: btw any better idea of a hack to try? Testers are pushing me - they want to upgrade the broken setup and I am blocking them :)

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-16 Thread Alexey Kardashevskiy
Hi! I am having problems when migrate a guest via libvirt like this: virsh migrate --live --persistent --undefinesource --copy-storage-all --verbose --desturi qemu+ssh://legkvm/system --domain chig1 The XML used to create the guest is at the end of this mail. I see NBD FLUSH command after the

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 14:02, Alexey Kardashevskiy ha scritto: I am having problems when migrate a guest via libvirt like this: virsh migrate --live --persistent --undefinesource --copy-storage-all --verbose --desturi qemu+ssh://legkvm/system --domain chig1 The XML used to create the guest is at

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-16 Thread Kevin Wolf
Am 16.09.2014 um 14:10 hat Paolo Bonzini geschrieben: Il 16/09/2014 14:02, Alexey Kardashevskiy ha scritto: I am having problems when migrate a guest via libvirt like this: virsh migrate --live --persistent --undefinesource --copy-storage-all --verbose --desturi qemu+ssh://legkvm/system

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 14:34, Kevin Wolf ha scritto: I think bdrv_invalidate_cache() really needs to call bdrv_drain_all() before starting to reopen stuff. There could be requests in flight without holding the lock and if you can indeed reopen their BDS under their feet without breaking things (I doubt

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-16 Thread Kevin Wolf
Am 16.09.2014 um 14:35 hat Paolo Bonzini geschrieben: Il 16/09/2014 14:34, Kevin Wolf ha scritto: I think bdrv_invalidate_cache() really needs to call bdrv_drain_all() before starting to reopen stuff. There could be requests in flight without holding the lock and if you can indeed reopen

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 14:52, Kevin Wolf ha scritto: Yes, that's true. We can't fix this problem in qcow2, though, because it's a more general one. I think we must make sure that bdrv_invalidate_cache() doesn't yield. Either by forbidding to run bdrv_invalidate_cache() in a coroutine and moving the

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-16 Thread Alexey Kardashevskiy
On 09/16/2014 10:10 PM, Paolo Bonzini wrote: Il 16/09/2014 14:02, Alexey Kardashevskiy ha scritto: I am having problems when migrate a guest via libvirt like this: virsh migrate --live --persistent --undefinesource --copy-storage-all --verbose --desturi qemu+ssh://legkvm/system --domain chig1

[Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex-locked == 1' failed

2014-09-15 Thread Alexey Kardashevskiy
Hi! I am hitting an racing issue with migration. I migrate a guest from one machine to another using libvirt: virsh migrate --live --persistent --undefinesource --copy-storage-all --verbose --desturi qemu+ssh://legkvm/system --domain chig1 I.e. it copied the full disk which is qcow2, 20G