Re: [Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-20 Thread andrzej zaborowski
Hi, On 17 February 2012 19:21, Peter Maydell peter.mayd...@linaro.org wrote: I'm looking at cleaning up some more omap3 patches, and have been working on the omap_i2c related ones. At the moment in omap_i2c.c there are the following #defines for the I2C module revision (as exposed via the

Re: [Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-20 Thread andrzej zaborowski
On 20 February 2012 13:12, andrzej zaborowski balr...@gmail.com wrote: I have neither of the TRMs at hand but I downloaded the TRM for omap35x which features i2c module 3.1 and it looks like the current Sorry, the revision is not given in the TRM, 3.1 is an example. Cheers

Re: [Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-20 Thread Peter Maydell
On 20 February 2012 12:12, andrzej zaborowski balr...@gmail.com wrote: On 17 February 2012 19:21, Peter Maydell peter.mayd...@linaro.org wrote: Does anybody know what the distinction between these two constants is supposed to be? They were introduced by commit 29885477 back in 2008... (Also,

[Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-17 Thread Peter Maydell
I'm looking at cleaning up some more omap3 patches, and have been working on the omap_i2c related ones. At the moment in omap_i2c.c there are the following #defines for the I2C module revision (as exposed via the revision register): #define OMAP2_INTR_REV 0x34 #define OMAP2_GC_REV 0x34 (plus a