Re: [Qemu-devel] qemu/xendisk: properly update stats in ioreq_release()

2012-05-14 Thread Stefano Stabellini
On Mon, 14 May 2012, Jan Beulich wrote: > >>> On 11.05.12 at 18:01, Stefano Stabellini > >>> > wrote: > > On Thu, 10 May 2012, Jan Beulich wrote: > >> While for the "normal" case (called from blk_send_response_all()) > >> decrementing requests_finished is correct, doing so in the parse error > >>

Re: [Qemu-devel] qemu/xendisk: properly update stats in ioreq_release()

2012-05-14 Thread Jan Beulich
>>> On 11.05.12 at 18:01, Stefano Stabellini wrote: > On Thu, 10 May 2012, Jan Beulich wrote: >> While for the "normal" case (called from blk_send_response_all()) >> decrementing requests_finished is correct, doing so in the parse error >> case is wrong; requests_inflight needs to be decremented i

Re: [Qemu-devel] qemu/xendisk: properly update stats in ioreq_release()

2012-05-11 Thread Stefano Stabellini
On Thu, 10 May 2012, Jan Beulich wrote: > While for the "normal" case (called from blk_send_response_all()) > decrementing requests_finished is correct, doing so in the parse error > case is wrong; requests_inflight needs to be decremented instead. > > Signed-off-by: Jan Beulich > > --- a/hw/xen

[Qemu-devel] qemu/xendisk: properly update stats in ioreq_release()

2012-05-10 Thread Jan Beulich
While for the "normal" case (called from blk_send_response_all()) decrementing requests_finished is correct, doing so in the parse error case is wrong; requests_inflight needs to be decremented instead. Signed-off-by: Jan Beulich --- a/hw/xen_disk.c +++ b/hw/xen_disk.c @@ -154,7 +154,7 @@ static