[Qemu-devel] qmp-commands.hx and inherited types (Was: Re: [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove)

2014-11-18 Thread John Snow
On 11/07/2014 08:00 AM, Eric Blake wrote: On 10/30/2014 04:22 AM, Fam Zheng wrote: [snip] +++ b/qapi/block-core.json @@ -865,6 +865,61 @@ '*on-target-error': 'BlockdevOnError' } } ## +# @BlockDirtyBitmap +# +# @device: name of device which the bitmap is tracking +# +# @name

Re: [Qemu-devel] qmp-commands.hx and inherited types (Was: Re: [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove)

2014-11-18 Thread Eric Blake
On 11/18/2014 09:44 AM, John Snow wrote: >> Is it worth using type inheritance, as in: >> >> { 'type': 'BlockDirtyBitmapAdd', >>'base': 'BlockDirtyBitmap', >>'data': { '*granularity': 'int' } } >> > > Strictly speaking, I would argue against inheritance here because > "BlockDirtyBitmapAdd"