Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-22 Thread Eric Blake
On 11/22/2016 04:22 PM, G 3 wrote: >> On the other hand, timestamp_put() (which now lives in qapi/qmp-event.c, >> rather than monitor.c) is still using qobject_from_jsonf() with PRId64 >> in current git master. If you don't want to hack the JSON parser (and I >> recommend that you don't), the alt

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-22 Thread G 3
On Nov 21, 2016, at 3:36 PM, Eric Blake wrote: On 11/21/2016 02:12 PM, G 3 wrote: On Nov 21, 2016, at 5:02 AM, Paolo Bonzini wrote: On 21/11/2016 07:30, G 3 wrote: When I try to use qemu-system-i386, I see this error message: qobject/qjson.c:69: failed assertion `obj != NULL'. The s

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-22 Thread Eric Blake
On 11/22/2016 09:02 AM, G 3 wrote: > > I did run make check. It fails here: > > GTESTER tests/check-qjson > qobject/qjson.c:69: failed assertion `obj != NULL' > GTester: last random seed: R02S40df2b0a1486871a176bb83135c07c90 > make: *** [/Users/john/desktop/qemu-2.0.0/tests/Makefile:343: > check-

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-22 Thread Markus Armbruster
Paolo Bonzini writes: >> > I kind of like the %-escapes, because they provide a compact and legible >> > way to build QObjects. But with so little use, they're hardly earning >> > their keep. >> >> What drives me most insane about them is that they are NOT the same >> escapes as printf(), so th

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-22 Thread G 3
On Nov 22, 2016, at 7:41 AM, Eric Blake wrote: On 11/22/2016 04:06 AM, Markus Armbruster wrote: Eric Blake writes: On 11/21/2016 02:36 PM, Eric Blake wrote: The source of your problem is that your platform defines PRId64 as 'qd', but the qemu JSON parser only recognizes lld (POSIX) or I64

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-22 Thread Paolo Bonzini
> > I kind of like the %-escapes, because they provide a compact and legible > > way to build QObjects. But with so little use, they're hardly earning > > their keep. > > What drives me most insane about them is that they are NOT the same > escapes as printf(), so the compiler can't help us with

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-22 Thread Eric Blake
On 11/22/2016 04:06 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 11/21/2016 02:36 PM, Eric Blake wrote: >>> The source of your problem is that your platform defines PRId64 as 'qd', >>> but the qemu JSON parser only recognizes lld (POSIX) or I64d (mingw) for >>> parsing 64-bit numbers

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-22 Thread Markus Armbruster
Eric Blake writes: > On 11/21/2016 02:36 PM, Eric Blake wrote: >> The source of your problem is that your platform defines PRId64 as 'qd', >> but the qemu JSON parser only recognizes lld (POSIX) or I64d (mingw) for >> parsing 64-bit numbers. We could enhance the JSON parser to recognize >> the n

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-21 Thread Paolo Bonzini
> On Nov 21, 2016, at 3:46 PM, Eric Blake wrote: > > On 11/21/2016 02:36 PM, Eric Blake wrote: > > > but I'd argue that using qobject_from_jsonf() is already less-than- > > > useful. > > > > In fact, we are down to only a handful of users of our modified > > 'jsonf' > > format (that is, strings th

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-21 Thread G 3
On Nov 21, 2016, at 3:46 PM, Eric Blake wrote: On 11/21/2016 02:36 PM, Eric Blake wrote: but I'd argue that using qobject_from_jsonf() is already less-than- useful. In fact, we are down to only a handful of users of our modified 'jsonf' format (that is, strings that mix JSON with % modifi

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-21 Thread Eric Blake
On 11/21/2016 02:36 PM, Eric Blake wrote: > but I'd argue that using qobject_from_jsonf() is already less-than-useful. In fact, we are down to only a handful of users of our modified 'jsonf' format (that is, strings that mix JSON with % modifiers): hw/pci/pcie_aer.c: build a 5-element QDict monit

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-21 Thread Eric Blake
On 11/21/2016 02:12 PM, G 3 wrote: > > On Nov 21, 2016, at 5:02 AM, Paolo Bonzini wrote: > >> >> >> On 21/11/2016 07:30, G 3 wrote: >>> When I try to use qemu-system-i386, I see this error message: >>> >>> qobject/qjson.c:69: failed assertion `obj != NULL'. >>> >>> The string argument is this: {

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-21 Thread G 3
On Nov 21, 2016, at 5:02 AM, Paolo Bonzini wrote: On 21/11/2016 07:30, G 3 wrote: When I try to use qemu-system-i386, I see this error message: qobject/qjson.c:69: failed assertion `obj != NULL'. This is the function where the assertion fails: /* * IMPORTANT: This function aborts on erro

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-21 Thread Paolo Bonzini
On 21/11/2016 07:30, G 3 wrote: > When I try to use qemu-system-i386, I see this error message: > > qobject/qjson.c:69: failed assertion `obj != NULL'. > > This is the function where the assertion fails: > > /* > * IMPORTANT: This function aborts on error, thus it must not > * be used with u

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-21 Thread Markus Armbruster
G 3 writes: > When I try to use qemu-system-i386, I see this error message: > > qobject/qjson.c:69: failed assertion `obj != NULL'. > > This is the function where the assertion fails: > > /* > * IMPORTANT: This function aborts on error, thus it must not > * be used with untrusted arguments. >

[Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-20 Thread G 3
When I try to use qemu-system-i386, I see this error message: qobject/qjson.c:69: failed assertion `obj != NULL'. This is the function where the assertion fails: /* * IMPORTANT: This function aborts on error, thus it must not * be used with untrusted arguments. */ QObject *qobject_from_jsonf