Re: [Qemu-devel] question regarding odd CPU feature assignement

2007-09-10 Thread Filip Navara
It's not a typo. The short story is that there are two CPUID feature registers - 1/EDX and 0x8001/EDX - that differ slightly. The later one was first used by AMD CPUs and mostly enhanced by adding new features to processors from the said company (3DNow and such). The first one was introduced

Re: [Qemu-devel] question regarding odd CPU feature assignement

2007-09-10 Thread Dan Kenigsberg
Thanks! On Mon, Sep 10, 2007 at 10:55:55AM +0200, Filip Navara wrote: It's not a typo. The short story is that there are two CPUID feature registers - 1/EDX and 0x8001/EDX - that differ slightly. The later one was first used by AMD CPUs and mostly enhanced by adding new features to

[Qemu-devel] question regarding odd CPU feature assignement

2007-09-09 Thread Dan Kenigsberg
Line 132 of qemu/target-i386/helper2.c has /* currently not enabled for std i386 because not fully tested */ env-cpuid_ext2_features = (env-cpuid_features 0x0183F3FF); Which smells like a typo: I see no reason to make cpuid_ext2_features a masked version of cpuid_features.