Re: [Qemu-devel] target-i386: block migration and savevm if invariant tsc is exposed (v3)

2014-04-25 Thread Marcelo Tosatti
On Fri, Apr 25, 2014 at 05:38:08PM -0300, Eduardo Habkost wrote: > Have you tested if your patch actually blocks savevm? Yes, with -smp 2. Can you please include the savevm.c patch in your queue? TIA.

Re: [Qemu-devel] target-i386: block migration and savevm if invariant tsc is exposed (v3)

2014-04-25 Thread Eduardo Habkost
On Thu, Apr 24, 2014 at 06:32:42PM -0300, Marcelo Tosatti wrote: > On Thu, Apr 24, 2014 at 04:21:59PM -0300, Eduardo Habkost wrote: > > On Wed, Apr 23, 2014 at 06:04:45PM -0300, Marcelo Tosatti wrote: > > > > > > Invariant TSC documentation mentions that "invariant TSC will run at a > > > constant

Re: [Qemu-devel] target-i386: block migration and savevm if invariant tsc is exposed (v3)

2014-04-25 Thread Marcelo Tosatti
On Thu, Apr 24, 2014 at 04:21:59PM -0300, Eduardo Habkost wrote: > On Wed, Apr 23, 2014 at 06:04:45PM -0300, Marcelo Tosatti wrote: > > > > Invariant TSC documentation mentions that "invariant TSC will run at a > > constant rate in all ACPI P-, C-. and T-states". > > > > This is not the case if m

Re: [Qemu-devel] target-i386: block migration and savevm if invariant tsc is exposed (v3)

2014-04-24 Thread Eduardo Habkost
On Wed, Apr 23, 2014 at 06:04:45PM -0300, Marcelo Tosatti wrote: > > Invariant TSC documentation mentions that "invariant TSC will run at a > constant rate in all ACPI P-, C-. and T-states". > > This is not the case if migration to a host with different TSC frequency > is allowed, or if savevm i

[Qemu-devel] target-i386: block migration and savevm if invariant tsc is exposed (v3)

2014-04-23 Thread Marcelo Tosatti
Invariant TSC documentation mentions that "invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states". This is not the case if migration to a host with different TSC frequency is allowed, or if savevm is performed. So block migration/savevm. Signed-off-by: Marcelo Tosatti Ind