Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-17 Thread Hans de Goede
Hi, On 11/16/2012 02:43 PM, Gerd Hoffmann wrote: On 11/16/12 12:24, Jan Kiszka wrote: On 2012-11-16 11:25, Gerd Hoffmann wrote: On 11/15/12 16:40, Jan Kiszka wrote: Hi Hans, On 2012-11-15 16:19, Hans de Goede wrote: Hi Jan, I just saw your $subject patch in Gerd's usb-next tree, and I've a

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-17 Thread Hans de Goede
Hi, On 11/16/2012 04:06 PM, Jan Kiszka wrote: On 2012-11-16 14:29, Hans de Goede wrote: Hi, On 11/15/2012 04:40 PM, Jan Kiszka wrote: Hi Hans, On 2012-11-15 16:19, Hans de Goede wrote: Hi Jan, I just saw your $subject patch in Gerd's usb-next tree, and I've a question about it. The token s

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-16 Thread Jan Kiszka
On 2012-11-16 14:29, Hans de Goede wrote: > Hi, > > On 11/15/2012 04:40 PM, Jan Kiszka wrote: >> Hi Hans, >> >> On 2012-11-15 16:19, Hans de Goede wrote: >>> Hi Jan, >>> >>> I just saw your $subject patch in Gerd's usb-next tree, and I've a question >>> about it. The token should be enough to uniq

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-16 Thread Gerd Hoffmann
On 11/16/12 12:24, Jan Kiszka wrote: > On 2012-11-16 11:25, Gerd Hoffmann wrote: >> On 11/15/12 16:40, Jan Kiszka wrote: >>> Hi Hans, >>> >>> On 2012-11-15 16:19, Hans de Goede wrote: Hi Jan, I just saw your $subject patch in Gerd's usb-next tree, and I've a question about it. T

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-16 Thread Hans de Goede
Hi, On 11/15/2012 04:40 PM, Jan Kiszka wrote: Hi Hans, On 2012-11-15 16:19, Hans de Goede wrote: Hi Jan, I just saw your $subject patch in Gerd's usb-next tree, and I've a question about it. The token should be enough to uniquely identify a device + ep, and unless a guest uses multiple qhs fo

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-16 Thread Jan Kiszka
On 2012-11-16 11:25, Gerd Hoffmann wrote: > On 11/15/12 16:40, Jan Kiszka wrote: >> Hi Hans, >> >> On 2012-11-15 16:19, Hans de Goede wrote: >>> Hi Jan, >>> >>> I just saw your $subject patch in Gerd's usb-next tree, and I've a question >>> about it. The token should be enough to uniquely identify

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-16 Thread Gerd Hoffmann
On 11/15/12 16:40, Jan Kiszka wrote: > Hi Hans, > > On 2012-11-15 16:19, Hans de Goede wrote: >> Hi Jan, >> >> I just saw your $subject patch in Gerd's usb-next tree, and I've a question >> about it. The token should be enough to uniquely identify a device + ep, >> and unless a guest uses multiple

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-15 Thread Jan Kiszka
Hi Hans, On 2012-11-15 16:19, Hans de Goede wrote: > Hi Jan, > > I just saw your $subject patch in Gerd's usb-next tree, and I've a question > about it. The token should be enough to uniquely identify a device + ep, > and unless a guest uses multiple qhs for a singe ep, that _should_ be enough.

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-15 Thread Hans de Goede
Hi Jan, I just saw your $subject patch in Gerd's usb-next tree, and I've a question about it. The token should be enough to uniquely identify a device + ep, and unless a guest uses multiple qhs for a singe ep, that _should_ be enough. So I'm wondering if you can give a (short) description of exa