Re: [Qemu-devel] value of VIRTQUEUE_MAX_SIZE

2015-02-06 Thread Eric Blake
On 02/06/2015 03:45 AM, Peter Lieven wrote: >>> The idea was that IOV_MAX is the limit in case of at least virtio-blk. The >>> host >>> will not support more than IOV_MAX iovecs passed to a block request. >> Is there an issue in practice? > > If there is no platform where IOV_MAX is less than 10

Re: [Qemu-devel] value of VIRTQUEUE_MAX_SIZE

2015-02-06 Thread Peter Lieven
Am 06.02.2015 um 11:42 schrieb Stefan Hajnoczi: > On Thu, Feb 05, 2015 at 03:29:17PM +0100, Peter Lieven wrote: >> Am 05.02.2015 um 15:00 schrieb Stefan Hajnoczi: >>> On Fri, Jan 30, 2015 at 10:08:02PM +0100, Peter Lieven wrote: Just wondering if VIRTQUEUE_MAX_SIZE in include/hw/virtio/virtio.

Re: [Qemu-devel] value of VIRTQUEUE_MAX_SIZE

2015-02-06 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 03:29:17PM +0100, Peter Lieven wrote: > Am 05.02.2015 um 15:00 schrieb Stefan Hajnoczi: > >On Fri, Jan 30, 2015 at 10:08:02PM +0100, Peter Lieven wrote: > >>Just wondering if VIRTQUEUE_MAX_SIZE in include/hw/virtio/virtio.h should > >>not be equal to IOV_MAX instead of the

Re: [Qemu-devel] value of VIRTQUEUE_MAX_SIZE

2015-02-05 Thread Peter Lieven
Am 05.02.2015 um 15:00 schrieb Stefan Hajnoczi: On Fri, Jan 30, 2015 at 10:08:02PM +0100, Peter Lieven wrote: Just wondering if VIRTQUEUE_MAX_SIZE in include/hw/virtio/virtio.h should not be equal to IOV_MAX instead of the hardcoded 1024? The vring queue size is guest-visible to some extent (e

Re: [Qemu-devel] value of VIRTQUEUE_MAX_SIZE

2015-02-05 Thread Stefan Hajnoczi
On Fri, Jan 30, 2015 at 10:08:02PM +0100, Peter Lieven wrote: > Just wondering if VIRTQUEUE_MAX_SIZE in include/hw/virtio/virtio.h should not > be equal to IOV_MAX instead of the hardcoded 1024? The vring queue size is guest-visible to some extent (e.g. vring memory layout). Tying it to a consta

[Qemu-devel] value of VIRTQUEUE_MAX_SIZE

2015-01-30 Thread Peter Lieven
Hi, Just wondering if VIRTQUEUE_MAX_SIZE in include/hw/virtio/virtio.h should not be equal to IOV_MAX instead of the hardcoded 1024? Thanks, Peter