Re: [Qemu-devel] vm internal snapshot deletes only delete first disk's snapshots

2015-07-14 Thread Marcus
Ok, this is weird. It looks like it dies on the first disk, which is the only one that actually gets its snapshot removed. Perhaps it is processing the first disk a second time? # virsh qemu-monitor-command i-2-38-VM --hmp 'delvm 1' Error while deleting snapshot on device 'virtio-disk0': Can't

Re: [Qemu-devel] vm internal snapshot deletes only delete first disk's snapshots

2015-07-14 Thread Marcus
Ok, I seem to have fixed it. I can submit a patch, but some input would be appreciated. In savevm.c, we have two functions: void hmp_delvm(Monitor *mon, const QDict *qdict), which my libvirt is using static int del_existing_snapshots(Monitor *mon, const char *name) These look to have the same

Re: [Qemu-devel] vm internal snapshot deletes only delete first disk's snapshots

2015-07-14 Thread Marcus
Looks like this is fixed in master. commit af957387547b05ed6dc4d84c10cca42700a7aeda Author: Zhang Haoyu zhan...@sangfor.com Date: Mon Sep 29 16:38:02 2014 +0800 snapshot: fix referencing wrong variable in while loop in do_delvm The while loop variabal is bs1, but bs is

[Qemu-devel] vm internal snapshot deletes only delete first disk's snapshots

2015-07-13 Thread Marcus
Hi all, I've recently been toying with VM snapshots, and have ran into an issue. Given a VM with multiple disks, it seems a snapshot-create followed by a snapshot-delete will only remove the qcow2 snapshot for the first disk (or perhaps just the disk that contains the memory), not all of the