Re: [RFC 0/4] POC: Generating realistic block errors

2019-11-26 Thread Kevin Wolf
Am 26.11.2019 um 19:19 hat Tony Asleson geschrieben: > On 11/21/19 4:30 AM, Stefan Hajnoczi wrote: > > blkdebug can inject EIO when a specific LBA is accessed. Is that > > enough for what you want to do? Then you can reuse and maybe extend > > blkdebug. > > Not exactly. For SCSI, I would like t

Re: [RFC 0/4] POC: Generating realistic block errors

2019-11-26 Thread Tony Asleson
On 11/21/19 4:30 AM, Stefan Hajnoczi wrote: > blkdebug can inject EIO when a specific LBA is accessed. Is that > enough for what you want to do? Then you can reuse and maybe extend > blkdebug. Not exactly. For SCSI, I would like to be able to return different types of device errors on reads eg.

Re: [RFC 0/4] POC: Generating realistic block errors

2019-11-21 Thread Kevin Wolf
Am 21.11.2019 um 11:30 hat Stefan Hajnoczi geschrieben: > On Thu, Nov 14, 2019 at 09:47:48AM -0600, Tony Asleson wrote: > > On 9/20/19 12:28 PM, Tony Asleson wrote: > > > On 9/20/19 4:22 AM, Stefan Hajnoczi wrote: > > >> blkdebug is purely at the QEMU block layer level. It is not aware of > > >> s

Re: [RFC 0/4] POC: Generating realistic block errors

2019-11-21 Thread Stefan Hajnoczi
On Thu, Nov 14, 2019 at 09:47:48AM -0600, Tony Asleson wrote: > On 9/20/19 12:28 PM, Tony Asleson wrote: > > On 9/20/19 4:22 AM, Stefan Hajnoczi wrote: > >> blkdebug is purely at the QEMU block layer level. It is not aware of > >> storage controller-specific error information or features. If you

Re: [RFC 0/4] POC: Generating realistic block errors

2019-11-14 Thread Tony Asleson
On 9/20/19 12:28 PM, Tony Asleson wrote: > On 9/20/19 4:22 AM, Stefan Hajnoczi wrote: >> blkdebug is purely at the QEMU block layer level. It is not aware of >> storage controller-specific error information or features. If you want >> to inject NVMe- or SCSI-specific errors that make no sense in

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-30 Thread Kevin Wolf
Am 20.09.2019 um 20:55 hat Tony Asleson geschrieben: > On 9/20/19 1:11 PM, Kevin Wolf wrote: > > Emitting a QMP event when blkdebug injects an error makes sense to me. > > > > I wouldn't use it for this case, though, because this would become racy. > > It could happen that the guest writes to the

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Tony Asleson
On 9/20/19 12:08 PM, Eric Blake wrote: > I am worried, however, that making data transactions have to go through > QMP to get an answer on how to handle a specific guest request will slow > things down; QMP is not built to be an efficient dataplane interface. IMHO we only need to make the code pat

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Tony Asleson
On 9/20/19 1:11 PM, Kevin Wolf wrote: > Emitting a QMP event when blkdebug injects an error makes sense to me. > > I wouldn't use it for this case, though, because this would become racy. > It could happen that the guest writes to the image, which sends a QMP > event, and then reads before the ext

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Kevin Wolf
Am 20.09.2019 um 18:41 hat Tony Asleson geschrieben: > On 9/20/19 3:36 AM, Kevin Wolf wrote: > > I/O error inserted by blkdebug can be one-off or permanent, but since it > > also supports using a small state machine, I think you should already be > > able to configure your errors that are corrected

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Tony Asleson
On 9/20/19 4:22 AM, Stefan Hajnoczi wrote: > blkdebug is purely at the QEMU block layer level. It is not aware of > storage controller-specific error information or features. If you want > to inject NVMe- or SCSI-specific errors that make no sense in QEMU's > block layer, then trying to do it in

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Eric Blake
On 9/20/19 11:41 AM, Tony Asleson wrote: > On 9/20/19 3:36 AM, Kevin Wolf wrote: >> I/O error inserted by blkdebug can be one-off or permanent, but since it >> also supports using a small state machine, I think you should already be >> able to configure your errors that are corrected by a rewrite,

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Tony Asleson
On 9/20/19 3:36 AM, Kevin Wolf wrote: > I/O error inserted by blkdebug can be one-off or permanent, but since it > also supports using a small state machine, I think you should already be > able to configure your errors that are corrected by a rewrite, too, even > if there is no explicit support fo

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190919194847.18518-1-tasle...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Stefan Hajnoczi
On Thu, Sep 19, 2019 at 02:48:43PM -0500, Tony Asleson wrote: > I've recently been informed that blkdebug exists. By the way, if error injection only needs to report media errors, then the existing blkdebug feature should be sufficient to do this. I think adding storage controller-specific error

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Stefan Hajnoczi
On Thu, Sep 19, 2019 at 02:48:43PM -0500, Tony Asleson wrote: > For a long time I thought that VMs could be a great way to improve OS > code quality by modifying the simulated hardware to return errors to > exercise error paths in the OSs, specifically in block devices for right now. > A number of

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Kevin Wolf
Am 19.09.2019 um 21:48 hat Tony Asleson geschrieben: > For a long time I thought that VMs could be a great way to improve OS > code quality by modifying the simulated hardware to return errors to > exercise error paths in the OSs, specifically in block devices for right now. > A number of different

[RFC 0/4] POC: Generating realistic block errors

2019-09-19 Thread Tony Asleson
For a long time I thought that VMs could be a great way to improve OS code quality by modifying the simulated hardware to return errors to exercise error paths in the OSs, specifically in block devices for right now. A number of different approaches are available within the Linux kernel, eg. scsi-d