Re: [RFC PATCH] docs/style: permit inline loop variables

2023-08-31 Thread Markus Armbruster
Peter Maydell writes: > On Wed, 23 Aug 2023 at 06:59, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > On Tue, 22 Aug 2023 at 16:50, Alex Bennée wrote: >> >> I've already wasted enough of my time debugging aliased variables in >> >> deeply nested loops. >> > >> > In theory we

Re: [RFC PATCH] docs/style: permit inline loop variables

2023-08-24 Thread Peter Maydell
On Wed, 23 Aug 2023 at 06:59, Markus Armbruster wrote: > > Peter Maydell writes: > > > On Tue, 22 Aug 2023 at 16:50, Alex Bennée wrote: > >> I've already wasted enough of my time debugging aliased variables in > >> deeply nested loops. > > > > In theory we could try to enable -Wshadow and deal

Re: [RFC PATCH] docs/style: permit inline loop variables

2023-08-23 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 22 Aug 2023 at 16:50, Alex Bennée wrote: >> I've already wasted enough of my time debugging aliased variables in >> deeply nested loops. > > In theory we could try to enable -Wshadow and deal with > all the existing cases of aliasing, which would then > allow us

Re: [RFC PATCH] docs/style: permit inline loop variables

2023-08-22 Thread Philippe Mathieu-Daudé
On 22/8/23 17:50, Alex Bennée wrote: I've already wasted enough of my time debugging aliased variables in deeply nested loops. While not scattering variable declarations around is a good aim I think we can make an exception for stuff used inside a loop. Signed-off-by: Alex Bennée ---

Re: [RFC PATCH] docs/style: permit inline loop variables

2023-08-22 Thread Thomas Huth
On 22/08/2023 17.50, Alex Bennée wrote: I've already wasted enough of my time debugging aliased variables in deeply nested loops. While not scattering variable declarations around is a good aim I think we can make an exception for stuff used inside a loop. Signed-off-by: Alex Bennée ---

Re: [RFC PATCH] docs/style: permit inline loop variables

2023-08-22 Thread Richard Henderson
On 8/22/23 08:50, Alex Bennée wrote: I've already wasted enough of my time debugging aliased variables in deeply nested loops. While not scattering variable declarations around is a good aim I think we can make an exception for stuff used inside a loop. Signed-off-by: Alex Bennée ---

Re: [RFC PATCH] docs/style: permit inline loop variables

2023-08-22 Thread Peter Maydell
On Tue, 22 Aug 2023 at 16:50, Alex Bennée wrote: > I've already wasted enough of my time debugging aliased variables in > deeply nested loops. In theory we could try to enable -Wshadow and deal with all the existing cases of aliasing, which would then allow us to turn it into an error and catch

Re: [RFC PATCH] docs/style: permit inline loop variables

2023-08-22 Thread Stefan Hajnoczi
On Tue, 22 Aug 2023 at 11:50, Alex Bennée wrote: > > I've already wasted enough of my time debugging aliased variables in > deeply nested loops. While not scattering variable declarations around > is a good aim I think we can make an exception for stuff used inside a > loop. > > Signed-off-by:

[RFC PATCH] docs/style: permit inline loop variables

2023-08-22 Thread Alex Bennée
I've already wasted enough of my time debugging aliased variables in deeply nested loops. While not scattering variable declarations around is a good aim I think we can make an exception for stuff used inside a loop. Signed-off-by: Alex Bennée --- docs/devel/style.rst | 9 - 1 file