Re: [RFC PATCH] include/hw: attempt to document VirtIO feature variables (!DISCUSS!)

2022-11-21 Thread Michael S. Tsirkin
On Mon, Nov 21, 2022 at 04:51:40PM -0500, Stefan Hajnoczi wrote: > On Mon, 21 Nov 2022 at 14:25, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > > > On Mon, 21 Nov 2022 at 09:49, Alex Bennée wrote: > > >> > > >> We have a bunch of variables associated with the device and the vhost > > >> ba

Re: [RFC PATCH] include/hw: attempt to document VirtIO feature variables (!DISCUSS!)

2022-11-21 Thread Stefan Hajnoczi
On Mon, 21 Nov 2022 at 14:25, Alex Bennée wrote: > Stefan Hajnoczi writes: > > > On Mon, 21 Nov 2022 at 09:49, Alex Bennée wrote: > >> > >> We have a bunch of variables associated with the device and the vhost > >> backend which are used inconsistently throughout the code base. Lets > >> start t

Re: [RFC PATCH] include/hw: attempt to document VirtIO feature variables (!DISCUSS!)

2022-11-21 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Mon, Nov 21, 2022 at 07:15:30PM +, Alex Bennée wrote: >> >> Stefan Hajnoczi writes: >> >> > On Mon, 21 Nov 2022 at 09:49, Alex Bennée wrote: >> >> >> >> We have a bunch of variables associated with the device and the vhost >> >> backend which are used i

Re: [RFC PATCH] include/hw: attempt to document VirtIO feature variables (!DISCUSS!)

2022-11-21 Thread Michael S. Tsirkin
On Mon, Nov 21, 2022 at 07:15:30PM +, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > On Mon, 21 Nov 2022 at 09:49, Alex Bennée wrote: > >> > >> We have a bunch of variables associated with the device and the vhost > >> backend which are used inconsistently throughout the code base. Le

Re: [RFC PATCH] include/hw: attempt to document VirtIO feature variables (!DISCUSS!)

2022-11-21 Thread Alex Bennée
Stefan Hajnoczi writes: > On Mon, 21 Nov 2022 at 09:49, Alex Bennée wrote: >> >> We have a bunch of variables associated with the device and the vhost >> backend which are used inconsistently throughout the code base. Lets >> start trying to bring some order by agreeing what each variable is >

Re: [RFC PATCH] include/hw: attempt to document VirtIO feature variables (!DISCUSS!)

2022-11-21 Thread Stefan Hajnoczi
On Mon, 21 Nov 2022 at 09:49, Alex Bennée wrote: > > We have a bunch of variables associated with the device and the vhost > backend which are used inconsistently throughout the code base. Lets > start trying to bring some order by agreeing what each variable is > for. Some cases to address (vho/v

[RFC PATCH] include/hw: attempt to document VirtIO feature variables (!DISCUSS!)

2022-11-21 Thread Alex Bennée
We have a bunch of variables associated with the device and the vhost backend which are used inconsistently throughout the code base. Lets start trying to bring some order by agreeing what each variable is for. Some cases to address (vho/vio renames to avoid ambiguous results while grepping): virt