Re: [External] Re: [RFC PATCH] migration: reduce time of loading non-iterable vmstate

2022-12-09 Thread Chuang Xu
Hi, Peter! This email is a supplement to my previous email 7 hours ago. On 2022/12/9 上午12:00, Peter Xu wrote: If the assert will work that'll be even better. I'm actually worried this can trigger like what you mentioned in the virtio path, I didn't expect it comes that soon. So if there's a mi

Re: [RFC PATCH] migration: reduce time of loading non-iterable vmstate

2022-12-08 Thread Chuang Xu
On 2022/12/9 上午12:00, Peter Xu wrote: On Thu, Dec 08, 2022 at 10:39:11PM +0800, Chuang Xu wrote: On 2022/12/8 上午6:08, Peter Xu wrote: On Thu, Dec 08, 2022 at 12:07:03AM +0800, Chuang Xu wrote: On 2022/12/6 上午12:28, Peter Xu wrote: Chuang, No worry on the delay; you're faster than when I read

Re: [RFC PATCH] migration: reduce time of loading non-iterable vmstate

2022-12-08 Thread Peter Xu
On Thu, Dec 08, 2022 at 10:39:11PM +0800, Chuang Xu wrote: > > On 2022/12/8 上午6:08, Peter Xu wrote: > > On Thu, Dec 08, 2022 at 12:07:03AM +0800, Chuang Xu wrote: > > > On 2022/12/6 上午12:28, Peter Xu wrote: > > > > Chuang, > > > > > > > > No worry on the delay; you're faster than when I read your

Re: [RFC PATCH] migration: reduce time of loading non-iterable vmstate

2022-12-08 Thread Chuang Xu
On 2022/12/8 上午6:08, Peter Xu wrote: On Thu, Dec 08, 2022 at 12:07:03AM +0800, Chuang Xu wrote: On 2022/12/6 上午12:28, Peter Xu wrote: Chuang, No worry on the delay; you're faster than when I read yours. :) On Mon, Dec 05, 2022 at 02:56:15PM +0800, Chuang Xu wrote: As a start, maybe you can

Re: [External] Re: [RFC PATCH] migration: reduce time of loading non-iterable vmstate

2022-12-07 Thread Peter Xu
On Thu, Dec 08, 2022 at 12:07:03AM +0800, Chuang Xu wrote: > > On 2022/12/6 上午12:28, Peter Xu wrote: > > Chuang, > > > > No worry on the delay; you're faster than when I read yours. :) > > > > On Mon, Dec 05, 2022 at 02:56:15PM +0800, Chuang Xu wrote: > > > > As a start, maybe you can try with p

Re: [External] Re: [RFC PATCH] migration: reduce time of loading non-iterable vmstate

2022-12-07 Thread Chuang Xu
On 2022/12/6 上午12:28, Peter Xu wrote: Chuang, No worry on the delay; you're faster than when I read yours. :) On Mon, Dec 05, 2022 at 02:56:15PM +0800, Chuang Xu wrote: As a start, maybe you can try with poison address_space_to_flatview() (by e.g. checking the start_pack_mr_change flag and as

Re: [RFC PATCH] migration: reduce time of loading non-iterable vmstate

2022-12-05 Thread Peter Xu
Chuang, No worry on the delay; you're faster than when I read yours. :) On Mon, Dec 05, 2022 at 02:56:15PM +0800, Chuang Xu wrote: > > As a start, maybe you can try with poison address_space_to_flatview() (by > > e.g. checking the start_pack_mr_change flag and assert it is not set) > > during thi

Re: [RFC PATCH] migration: reduce time of loading non-iterable vmstate

2022-12-04 Thread Chuang Xu
Peter, I'm sorry I didn't reply to your email in time, because I was busy with other work last week. Here is my latest progress. On 2022/11/29 上午1:41, Peter Xu wrote: On Mon, Nov 28, 2022 at 05:42:43PM +0800, Chuang Xu wrote: On 2022/11/25 上午12:40, Peter Xu wrote: On Fri, Nov 18, 2022 at 04:36

Re: [RFC PATCH] migration: reduce time of loading non-iterable vmstate

2022-11-28 Thread Peter Xu
On Mon, Nov 28, 2022 at 05:42:43PM +0800, Chuang Xu wrote: > > On 2022/11/25 上午12:40, Peter Xu wrote: > > On Fri, Nov 18, 2022 at 04:36:48PM +0800, Chuang Xu wrote: > > > The duration of loading non-iterable vmstate accounts for a significant > > > portion of downtime (starting with the timestamp

Re: [RFC PATCH] migration: reduce time of loading non-iterable vmstate

2022-11-28 Thread Chuang Xu
On 2022/11/25 上午12:40, Peter Xu wrote: On Fri, Nov 18, 2022 at 04:36:48PM +0800, Chuang Xu wrote: The duration of loading non-iterable vmstate accounts for a significant portion of downtime (starting with the timestamp of source qemu stop and ending with the timestamp of target qemu start). Mos

Re: [RFC PATCH] migration: reduce time of loading non-iterable vmstate

2022-11-24 Thread Peter Xu
On Fri, Nov 18, 2022 at 04:36:48PM +0800, Chuang Xu wrote: > The duration of loading non-iterable vmstate accounts for a significant > portion of downtime (starting with the timestamp of source qemu stop and > ending with the timestamp of target qemu start). Most of the time is spent > committing m

[RFC PATCH] migration: reduce time of loading non-iterable vmstate

2022-11-18 Thread Chuang Xu
The duration of loading non-iterable vmstate accounts for a significant portion of downtime (starting with the timestamp of source qemu stop and ending with the timestamp of target qemu start). Most of the time is spent committing memory region changes repeatedly. This patch packs all the changes