Re: [RFC PATCH] qemu-keymap: properly check return from xkb_keymap_mod_get_index

2023-06-20 Thread Peter Maydell
On Tue, 20 Jun 2023 at 16:55, Richard Henderson wrote: > > On 6/20/23 17:37, Alex Bennée wrote: > > ar maybe? it only got flagged in clang-system once fedora was updated (I > > assume with better sanitizers): > > > >[2773/3696] Generating pc-bios/keymaps/ar with a custom command > >

Re: [RFC PATCH] qemu-keymap: properly check return from xkb_keymap_mod_get_index

2023-06-20 Thread Richard Henderson
On 6/20/23 17:37, Alex Bennée wrote: ar maybe? it only got flagged in clang-system once fedora was updated (I assume with better sanitizers): [2773/3696] Generating pc-bios/keymaps/ar with a custom command FAILED: pc-bios/keymaps/ar /builds/stsquad/qemu/build/qemu-keymap -f

Re: [RFC PATCH] qemu-keymap: properly check return from xkb_keymap_mod_get_index

2023-06-20 Thread Peter Maydell
On Tue, 20 Jun 2023 at 16:38, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Tue, 20 Jun 2023 at 16:04, Alex Bennée wrote: > >> > >> We can return XKB_MOD_INVALID which rightly gets flagged by sanitisers > >> as an overly wide shift attempt. > >> > >> Signed-off-by: Alex Bennée > >>

Re: [RFC PATCH] qemu-keymap: properly check return from xkb_keymap_mod_get_index

2023-06-20 Thread Alex Bennée
Peter Maydell writes: > On Tue, 20 Jun 2023 at 16:04, Alex Bennée wrote: >> >> We can return XKB_MOD_INVALID which rightly gets flagged by sanitisers >> as an overly wide shift attempt. >> >> Signed-off-by: Alex Bennée >> --- >> qemu-keymap.c | 24 >> 1 file

Re: [RFC PATCH] qemu-keymap: properly check return from xkb_keymap_mod_get_index

2023-06-20 Thread Peter Maydell
On Tue, 20 Jun 2023 at 16:04, Alex Bennée wrote: > > We can return XKB_MOD_INVALID which rightly gets flagged by sanitisers > as an overly wide shift attempt. > > Signed-off-by: Alex Bennée > --- > qemu-keymap.c | 24 > 1 file changed, 16 insertions(+), 8 deletions(-)

[RFC PATCH] qemu-keymap: properly check return from xkb_keymap_mod_get_index

2023-06-20 Thread Alex Bennée
We can return XKB_MOD_INVALID which rightly gets flagged by sanitisers as an overly wide shift attempt. Signed-off-by: Alex Bennée --- qemu-keymap.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/qemu-keymap.c b/qemu-keymap.c index