Re: [RFC PATCH] qom: Implement qom-get HMP command

2020-05-21 Thread Paolo Bonzini
On 20/05/20 11:59, Dr. David Alan Gilbert wrote: >> Count me in favour. I'd like to see the matching change to HMP qom-set, >> though. > It turns out I actually did do a JSON version, as the follow up to the > version Cédric reposted; but then that got lost in people not liking > JSON;

Re: [RFC PATCH] qom: Implement qom-get HMP command

2020-05-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Cédric Le Goater writes: > >> > >> > From: "Dr. David Alan Gilbert" > >> > > >> > Reimplement it based on qmp_qom_get() to avoid converting QObjects

Re: [RFC PATCH] qom: Implement qom-get HMP command

2020-05-08 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Cédric Le Goater writes: >> >> > From: "Dr. David Alan Gilbert" >> > >> > Reimplement it based on qmp_qom_get() to avoid converting QObjects back >> > to strings. >> > >> > Inspired-by: Paolo Bonzini >> >

Re: [RFC PATCH] qom: Implement qom-get HMP command

2020-05-07 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Cédric Le Goater writes: > > > From: "Dr. David Alan Gilbert" > > > > Reimplement it based on qmp_qom_get() to avoid converting QObjects back > > to strings. > > > > Inspired-by: Paolo Bonzini > > Signed-off-by: Andreas Färber > > > > Slight

Re: [RFC PATCH] qom: Implement qom-get HMP command

2020-05-02 Thread Markus Armbruster
Cédric Le Goater writes: > From: "Dr. David Alan Gilbert" > > Reimplement it based on qmp_qom_get() to avoid converting QObjects back > to strings. > > Inspired-by: Paolo Bonzini > Signed-off-by: Andreas Färber > > Slight fix for bit-rot: > Signed-off-by: Dr. David Alan Gilbert > [clg:

Re: [RFC PATCH] qom: Implement qom-get HMP command

2020-04-29 Thread Cédric Le Goater
On 4/27/20 9:19 PM, Dr. David Alan Gilbert wrote: > * Cédric Le Goater (c...@kaod.org) wrote: >> From: "Dr. David Alan Gilbert" >> >> Reimplement it based on qmp_qom_get() to avoid converting QObjects back >> to strings. > > > I'd love to see this or something similar in; what does it's output

Re: [RFC PATCH] qom: Implement qom-get HMP command

2020-04-27 Thread Dr. David Alan Gilbert
* Cédric Le Goater (c...@kaod.org) wrote: > From: "Dr. David Alan Gilbert" > > Reimplement it based on qmp_qom_get() to avoid converting QObjects back > to strings. I'd love to see this or something similar in; what does it's output look like for structures - I think that was the main problem

[RFC PATCH] qom: Implement qom-get HMP command

2020-04-07 Thread Cédric Le Goater
From: "Dr. David Alan Gilbert" Reimplement it based on qmp_qom_get() to avoid converting QObjects back to strings. Inspired-by: Paolo Bonzini Signed-off-by: Andreas Färber Slight fix for bit-rot: Signed-off-by: Dr. David Alan Gilbert [clg: updates for QEMU 5.0 ] Signed-off-by: Cédric Le