Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-06-22 Thread Richard Henderson
On 6/22/23 22:55, BALATON Zoltan wrote: Hello, What happened to this patch? Will this be merged by somebody? Thanks for the reminder. Queued to tcg-next. r~ Regards, BALATON Zoltan On Tue, 23 May 2023, BALATON Zoltan wrote: On Tue, 23 May 2023, Alex Bennée wrote: Balton discovered that

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-06-22 Thread BALATON Zoltan
Hello, What happened to this patch? Will this be merged by somebody? Regards, BALATON Zoltan On Tue, 23 May 2023, BALATON Zoltan wrote: On Tue, 23 May 2023, Alex Bennée wrote: Balton discovered that asserts for the extract/deposit calls had a Missing an a in my name and my given name is Zol

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-05-26 Thread BALATON Zoltan
On Tue, 23 May 2023, BALATON Zoltan wrote: Unrelated to this patch I also started to see random crashes with a DSI on a dcbz instruction now which did not happen before (or not frequently enough for me to notice). I did not bisect that as it happens randomly but I wonder if it could be related

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-05-25 Thread BALATON Zoltan
On Thu, 25 May 2023, Paolo Bonzini wrote: On 5/23/23 16:33, Richard Henderson wrote: The tests are poorly ordered, testing many unlikely things before the most likely thing (normal).  A better ordering would be     if (likely(tp##_is_normal(arg))) {     } else if (tp##_is_zero(arg)) {    

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-05-25 Thread BALATON Zoltan
On Thu, 25 May 2023, Paolo Bonzini wrote: On 5/23/23 16:33, Richard Henderson wrote: The tests are poorly ordered, testing many unlikely things before the most likely thing (normal).  A better ordering would be     if (likely(tp##_is_normal(arg))) {     } else if (tp##_is_zero(arg)) {     }

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-05-25 Thread Paolo Bonzini
On 5/23/23 16:33, Richard Henderson wrote: The tests are poorly ordered, testing many unlikely things before the most likely thing (normal).  A better ordering would be     if (likely(tp##_is_normal(arg))) {     } else if (tp##_is_zero(arg)) {     } else if (tp##_is_zero_or_denormal(arg))

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-05-25 Thread Richard Henderson
On 5/25/23 06:22, Paolo Bonzini wrote: On 5/23/23 16:33, Richard Henderson wrote: The tests are poorly ordered, testing many unlikely things before the most likely thing (normal).  A better ordering would be if (likely(tp##_is_normal(arg))) { } else if (tp##_is_zero(arg)) { }

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-05-25 Thread Paolo Bonzini
On 5/23/23 16:33, Richard Henderson wrote: The tests are poorly ordered, testing many unlikely things before the most likely thing (normal).  A better ordering would be     if (likely(tp##_is_normal(arg))) {     } else if (tp##_is_zero(arg)) {     } else if (tp##_is_zero_or_denormal(arg))

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-05-23 Thread BALATON Zoltan
On Tue, 23 May 2023, Richard Henderson wrote: On 5/23/23 06:57, BALATON Zoltan wrote: This solves the softfloat related usages, the rest probably are lower overhead, I could not measure any more improvement with removing asserts on top of this patch. I still have these functions high in my prof

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-05-23 Thread Richard Henderson
On 5/23/23 06:11, Alex Bennée wrote: Balton discovered that asserts for the extract/deposit calls had a significant impact on a lame benchmark on qemu-ppc. Replicating with: ./qemu-ppc64 ~/lsrc/tests/lame.git-svn/builds/ppc64/frontend/lame \ -h pts-trondheim-3.wav pts-trondheim-3.mp3 sh

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-05-23 Thread Richard Henderson
On 5/23/23 06:57, BALATON Zoltan wrote: This solves the softfloat related usages, the rest probably are lower overhead, I could not measure any more improvement with removing asserts on top of this patch. I still have these functions high in my profiling result: children  self    command  

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-05-23 Thread Philippe Mathieu-Daudé
On 23/5/23 15:11, Alex Bennée wrote: Balton discovered that asserts for the extract/deposit calls had a Zoltan significant impact on a lame benchmark on qemu-ppc. Replicating with: ./qemu-ppc64 ~/lsrc/tests/lame.git-svn/builds/ppc64/frontend/lame \ -h pts-trondheim-3.wav pts-trondhei

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-05-23 Thread BALATON Zoltan
On Tue, 23 May 2023, Alex Bennée wrote: Balton discovered that asserts for the extract/deposit calls had a Missing an a in my name and my given name is Zoltan. (First name and last name is in the other way in Hungarian.) Maybe just add a Reported-by instead of here if you want to record it.

[RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-05-23 Thread Alex Bennée
Balton discovered that asserts for the extract/deposit calls had a significant impact on a lame benchmark on qemu-ppc. Replicating with: ./qemu-ppc64 ~/lsrc/tests/lame.git-svn/builds/ppc64/frontend/lame \ -h pts-trondheim-3.wav pts-trondheim-3.mp3 showed up the pack/unpack routines not elid