Re: [RFC PATCH] target/ppc: fix vector registers access in gdbstub for little-endian

2021-08-16 Thread Matheus K. Ferst
On 13/08/2021 06:17, Peter Maydell wrote: [E-MAIL EXTERNO] Não clique em links ou abra anexos, a menos que você possa confirmar o remetente e saber que o conteúdo é seguro. Em caso de e-mail suspeito entre imediatamente em contato com o DTI. On Thu, 12 Aug 2021 at 21:07, Richard Henderson wro

Re: [RFC PATCH] target/ppc: fix vector registers access in gdbstub for little-endian

2021-08-13 Thread Peter Maydell
On Thu, 12 Aug 2021 at 21:07, Richard Henderson wrote: > > On 8/12/21 9:10 AM, matheus.fe...@eldorado.org.br wrote: > > static bool avr_need_swap(CPUPPCState *env) > > { > > +bool le; > > +#if defined(CONFIG_USER_ONLY) > > +le = false; > > +#else > > +le = msr_le; > > +#endif > > I

Re: [RFC PATCH] target/ppc: fix vector registers access in gdbstub for little-endian

2021-08-12 Thread Richard Henderson
On 8/12/21 9:10 AM, matheus.fe...@eldorado.org.br wrote: static bool avr_need_swap(CPUPPCState *env) { +bool le; +#if defined(CONFIG_USER_ONLY) +le = false; +#else +le = msr_le; +#endif It certainly doesn't seem like the right fix. My first guess was that MSR_LE wasn't being pr

[RFC PATCH] target/ppc: fix vector registers access in gdbstub for little-endian

2021-08-12 Thread matheus . ferst
From: Matheus Ferst It seems that access to elements of ppc_avr_t should only depend on msr_le when !CONFIG_USER_ONLY. Signed-off-by: Matheus Ferst --- To reproduce the problem, build the following program for ppc64le: int main(void) { __uint128_t a = 0x1122334455667788llu; a <<= 64;