Re: [RFC PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is also advertised

2019-10-10 Thread Evgeny Yakovlev
On 09.10.2019 22:14, Michael S. Tsirkin wrote: On Tue, Oct 08, 2019 at 02:24:16PM +0100, Stefan Hajnoczi wrote: On Fri, Sep 20, 2019 at 02:56:30PM +0300, Evgeny Yakovlev wrote: Virtio spec 1.1 (and earlier), 5.2.5.1 Driver Requirements: Device Initialization: "Devices SHOULD always offer VIRTI

Re: [RFC PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is also advertised

2019-10-09 Thread Michael S. Tsirkin
On Tue, Oct 08, 2019 at 02:24:16PM +0100, Stefan Hajnoczi wrote: > On Fri, Sep 20, 2019 at 02:56:30PM +0300, Evgeny Yakovlev wrote: > > Virtio spec 1.1 (and earlier), 5.2.5.1 Driver Requirements: Device > > Initialization: > > > > "Devices SHOULD always offer VIRTIO_BLK_F_FLUSH, and MUST offer it

Re: [RFC PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is also advertised

2019-10-09 Thread Stefan Hajnoczi
On Wed, Oct 09, 2019 at 03:37:35PM +0300, Evgeny Yakovlev wrote: > On 08.10.2019 16:24, Stefan Hajnoczi wrote: > > On Fri, Sep 20, 2019 at 02:56:30PM +0300, Evgeny Yakovlev wrote: > > The motivation for this change looks correct but this patch may cause > > host_features to change across live migra

Re: [RFC PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is also advertised

2019-10-09 Thread Evgeny Yakovlev
On 08.10.2019 16:24, Stefan Hajnoczi wrote: On Fri, Sep 20, 2019 at 02:56:30PM +0300, Evgeny Yakovlev wrote: Virtio spec 1.1 (and earlier), 5.2.5.1 Driver Requirements: Device Initialization: "Devices SHOULD always offer VIRTIO_BLK_F_FLUSH, and MUST offer it if they offer VIRTIO_BLK_F_CONFIG_

Re: [RFC PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is also advertised

2019-10-08 Thread Stefan Hajnoczi
On Fri, Sep 20, 2019 at 02:56:30PM +0300, Evgeny Yakovlev wrote: > Virtio spec 1.1 (and earlier), 5.2.5.1 Driver Requirements: Device > Initialization: > > "Devices SHOULD always offer VIRTIO_BLK_F_FLUSH, and MUST offer it if > they offer VIRTIO_BLK_F_CONFIG_WCE. > > It looks like currently F_CON

[RFC PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is also advertised

2019-09-20 Thread Evgeny Yakovlev
Virtio spec 1.1 (and earlier), 5.2.5.1 Driver Requirements: Device Initialization: "Devices SHOULD always offer VIRTIO_BLK_F_FLUSH, and MUST offer it if they offer VIRTIO_BLK_F_CONFIG_WCE. It looks like currently F_CONFIG_WCE and F_WCE are not connected to each other. qemu will advertise F_CONFIG