Re: [RFC PATCH 0/1] Removing RAMBlocks during migration

2020-01-13 Thread Yury Kotov
Hi! 07.01.2020, 23:08, "Michael S. Tsirkin" : > On Fri, Jan 03, 2020 at 11:44:27AM +, Dr. David Alan Gilbert wrote: >>  > 1) Guest: writes to slot's pci config >>  > 2) QEMU: pcie_cap_slot_write_config -> pcie_unplug_device >>  > >>  > So, it's only guest driven action and qdev_unplug doesn't

Re: [RFC PATCH 0/1] Removing RAMBlocks during migration

2020-01-08 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Mon, Dec 09, 2019 at 10:41:01AM +0300, Yury Kotov wrote: >> Hi, >> >> I found that it's possible to remove a RAMBlock during migration. >> E.g. device hot-unplugging initiated by a guest (how to reproduce is below). >> And I want to clarify whether RAMBlock removi

Re: [RFC PATCH 0/1] Removing RAMBlocks during migration

2020-01-08 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, Jan 03, 2020 at 11:44:27AM +, Dr. David Alan Gilbert wrote: > > > 1) Guest: writes to slot's pci config > > > 2) QEMU: pcie_cap_slot_write_config -> pcie_unplug_device > > > > > > So, it's only guest driven action and qdev_unplug doesn't

Re: [RFC PATCH 0/1] Removing RAMBlocks during migration

2020-01-07 Thread Michael S. Tsirkin
On Fri, Jan 03, 2020 at 11:44:27AM +, Dr. David Alan Gilbert wrote: > > 1) Guest: writes to slot's pci config > > 2) QEMU: pcie_cap_slot_write_config -> pcie_unplug_device > > > > So, it's only guest driven action and qdev_unplug doesn't help here. > > Hmm we need to find a way to stop that;

Re: [RFC PATCH 0/1] Removing RAMBlocks during migration

2020-01-07 Thread Michael S. Tsirkin
On Mon, Dec 09, 2019 at 10:41:01AM +0300, Yury Kotov wrote: > Hi, > > I found that it's possible to remove a RAMBlock during migration. > E.g. device hot-unplugging initiated by a guest (how to reproduce is below). > And I want to clarify whether RAMBlock removing (or even adding) during > migrati

Re: [RFC PATCH 0/1] Removing RAMBlocks during migration

2020-01-03 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > Hi! > > 11.12.2019, 14:17, "Dr. David Alan Gilbert" : > > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: > >>  Hi, > >> > >>  I found that it's possible to remove a RAMBlock during migration. > >>  E.g. device hot-unplugging initiated by a guest (

Re: [RFC PATCH 0/1] Removing RAMBlocks during migration

2019-12-23 Thread Yury Kotov
Hi! 11.12.2019, 14:17, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  Hi, >> >>  I found that it's possible to remove a RAMBlock during migration. >>  E.g. device hot-unplugging initiated by a guest (how to reproduce is below). >>  And I want to clarify whether RA

Re: [RFC PATCH 0/1] Removing RAMBlocks during migration

2019-12-11 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > Hi, > > I found that it's possible to remove a RAMBlock during migration. > E.g. device hot-unplugging initiated by a guest (how to reproduce is below). > And I want to clarify whether RAMBlock removing (or even adding) during > migration is valid

[RFC PATCH 0/1] Removing RAMBlocks during migration

2019-12-08 Thread Yury Kotov
Hi, I found that it's possible to remove a RAMBlock during migration. E.g. device hot-unplugging initiated by a guest (how to reproduce is below). And I want to clarify whether RAMBlock removing (or even adding) during migration is valid operation or it's a bug. Currently, it may cause some race