Re: [RFC PATCH 06/34] exec: [VADDR] Move vaddr defines to separate file

2024-01-27 Thread Richard Henderson
On 1/27/24 18:36, Richard Henderson wrote: On 1/20/24 00:39, Anton Johansson wrote: --- a/include/exec/cpu-common.h +++ b/include/exec/cpu-common.h @@ -14,18 +14,6 @@   #define EXCP_YIELD  0x10004 /* cpu wants to yield timeslice to another */   #define EXCP_ATOMIC 0x10005 /*

Re: [RFC PATCH 06/34] exec: [VADDR] Move vaddr defines to separate file

2024-01-27 Thread Richard Henderson
On 1/20/24 00:39, Anton Johansson wrote: --- a/include/exec/cpu-common.h +++ b/include/exec/cpu-common.h @@ -14,18 +14,6 @@ #define EXCP_YIELD 0x10004 /* cpu wants to yield timeslice to another */ #define EXCP_ATOMIC 0x10005 /* stop-the-world and emulate atomic */ -/** - *

Re: [RFC PATCH 06/34] exec: [VADDR] Move vaddr defines to separate file

2024-01-23 Thread Richard Henderson
On 1/20/24 00:39, Anton Johansson wrote: +++ b/include/exec/vaddr.h @@ -0,0 +1,18 @@ +/* Define vaddr if it exists. */ s/if it exists// Need a license line here. Otherwise. Reviewed-by: Richard Henderson r~

[RFC PATCH 06/34] exec: [VADDR] Move vaddr defines to separate file

2024-01-19 Thread Anton Johansson via
Needed to work around circular includes. vaddr is currently defined in cpu-common.h and needed by hw/core/cpu.h, but cpu-common.h also need cpu.h to know the size of the CPUState. [Maybe we can instead move parts of cpu-common.h w. hw/core/cpu.h to sort out the circular inclusion.]