Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-20 Thread Peter Krempa
On Thu, Aug 20, 2020 at 09:41:14 -0500, Eric Blake wrote: > On 8/20/20 6:05 AM, Kevin Wolf wrote: > > > As long as we can keep the compatibility code local to qmp_nbd_*(), I > > don't think it's too bad. In particular because it's already written. > > > > Instead of adjusting libvirt to changes

Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-20 Thread Eric Blake
On 8/20/20 6:05 AM, Kevin Wolf wrote: As long as we can keep the compatibility code local to qmp_nbd_*(), I don't think it's too bad. In particular because it's already written. Instead of adjusting libvirt to changes in the nbd-* commands, I'd rather have it change over to block-export-*. I

Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-20 Thread Kevin Wolf
Am 19.08.2020 um 21:50 hat Eric Blake geschrieben: > cc: Peter Krempa > > On 8/13/20 11:29 AM, Kevin Wolf wrote: > > nbd-server-add tries to be convenient and adds two questionable > > features that we don't want to share in block-export-add, even for NBD > > exports: > > > > 1. When requesting

Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-19 Thread Eric Blake
cc: Peter Krempa On 8/13/20 11:29 AM, Kevin Wolf wrote: nbd-server-add tries to be convenient and adds two questionable features that we don't want to share in block-export-add, even for NBD exports: 1. When requesting a writable export of a read-only device, the export is silently

Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-17 Thread Max Reitz
On 17.08.20 14:49, Kevin Wolf wrote: > Am 17.08.2020 um 13:41 hat Max Reitz geschrieben: >> On 13.08.20 18:29, Kevin Wolf wrote: >>> nbd-server-add tries to be convenient and adds two questionable >>> features that we don't want to share in block-export-add, even for NBD >>> exports: >>> >>> 1.

Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-17 Thread Kevin Wolf
Am 17.08.2020 um 13:41 hat Max Reitz geschrieben: > On 13.08.20 18:29, Kevin Wolf wrote: > > nbd-server-add tries to be convenient and adds two questionable > > features that we don't want to share in block-export-add, even for NBD > > exports: > > > > 1. When requesting a writable export of a

Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-17 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > nbd-server-add tries to be convenient and adds two questionable > features that we don't want to share in block-export-add, even for NBD > exports: > > 1. When requesting a writable export of a read-only device, the export >is silently downgraded to

[RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-13 Thread Kevin Wolf
nbd-server-add tries to be convenient and adds two questionable features that we don't want to share in block-export-add, even for NBD exports: 1. When requesting a writable export of a read-only device, the export is silently downgraded to read-only. This should be an error in the context