Re: [RFC PATCH 1/1] Dirty quota-based throttling of vcpus

2023-02-13 Thread Shivam Kumar
On 22/11/22 9:30 am, Shivam Kumar wrote: On 21/11/22 5:05 pm, Philippe Mathieu-Daudé wrote: Hi, On 20/11/22 23:54, Shivam Kumar wrote: + +void dirty_quota_migration_start(void) +{ +    if (!kvm_state->dirty_quota_supported) { You are accessing an accelerator-specific variable in an acc

Re: [RFC PATCH 1/1] Dirty quota-based throttling of vcpus

2022-11-22 Thread Shivam Kumar
On 21/11/22 5:05 pm, Philippe Mathieu-Daudé wrote: Hi, On 20/11/22 23:54, Shivam Kumar wrote: + +void dirty_quota_migration_start(void) +{ +    if (!kvm_state->dirty_quota_supported) { You are accessing an accelerator-specific variable in an accelerator-agnostic file, this doesn't sound c

Re: [RFC PATCH 1/1] Dirty quota-based throttling of vcpus

2022-11-21 Thread Philippe Mathieu-Daudé
Hi, On 20/11/22 23:54, Shivam Kumar wrote: Introduces a (new) throttling scheme where QEMU defines a limit on the dirty rate of each vcpu of the VM. This limit is enfored on the vcpus in small intervals (dirty quota intervals) by allowing the vcpus to dirty only as many pages in these intervals

[RFC PATCH 1/1] Dirty quota-based throttling of vcpus

2022-11-20 Thread Shivam Kumar
Introduces a (new) throttling scheme where QEMU defines a limit on the dirty rate of each vcpu of the VM. This limit is enfored on the vcpus in small intervals (dirty quota intervals) by allowing the vcpus to dirty only as many pages in these intervals as to maintain a dirty rate below the set limi