Re: [RFC PATCH 1/4] target/riscv/kvm: add software breakpoints support

2024-05-26 Thread Chao Du
On 2024-05-25 00:11, Paolo Bonzini wrote: > > On Tue, Apr 16, 2024 at 11:23 AM Daniel Henrique Barboza > wrote: > > > +int kvm_arch_insert_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint > > > *bp, > > > + vaddr len) > > > +{ > > > +if (len != 4 && len

Re: [RFC PATCH 1/4] target/riscv/kvm: add software breakpoints support

2024-05-24 Thread Paolo Bonzini
On Tue, Apr 16, 2024 at 11:23 AM Daniel Henrique Barboza wrote: > > +int kvm_arch_insert_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint > > *bp, > > + vaddr len) > > +{ > > +if (len != 4 && len != 2) { > > +return -EINVAL; > > +} > > I

Re: [RFC PATCH 1/4] target/riscv/kvm: add software breakpoints support

2024-04-18 Thread Chao Du
On 2024-04-16 17:23, Daniel Henrique Barboza wrote: > > On 12/21/23 06:49, Chao Du wrote: > > This patch implements insert/remove software breakpoint process: > > > > Add an input parameter for kvm_arch_insert_sw_breakpoint() and > > kvm_arch_remove_sw_breakpoint() to pass the length

Re: [RFC PATCH 1/4] target/riscv/kvm: add software breakpoints support

2024-04-16 Thread Daniel Henrique Barboza
On 12/21/23 06:49, Chao Du wrote: This patch implements insert/remove software breakpoint process: Add an input parameter for kvm_arch_insert_sw_breakpoint() and kvm_arch_remove_sw_breakpoint() to pass the length information, which helps us to know whether it is a compressed instruction. For

[RFC PATCH 1/4] target/riscv/kvm: add software breakpoints support

2023-12-21 Thread Chao Du
This patch implements insert/remove software breakpoint process: Add an input parameter for kvm_arch_insert_sw_breakpoint() and kvm_arch_remove_sw_breakpoint() to pass the length information, which helps us to know whether it is a compressed instruction. For some remove cases, we do not have the