Re: [RFC PATCH 11/42] target/mips/tx79: Move PCPYH opcode to decodetree

2021-03-09 Thread Richard Henderson
On 3/8/21 3:57 AM, Philippe Mathieu-Daudé wrote: On 3/8/21 11:48 AM, Philippe Mathieu-Daudé wrote: On 2/15/21 5:26 PM, Richard Henderson wrote: On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote: +if (a->rt == 0) { +tcg_gen_movi_i64(cpu_gpr[a->rd], 0); +tcg_gen_movi_i64(cpu_g

Re: [RFC PATCH 11/42] target/mips/tx79: Move PCPYH opcode to decodetree

2021-03-08 Thread Philippe Mathieu-Daudé
On 3/8/21 11:48 AM, Philippe Mathieu-Daudé wrote: > On 2/15/21 5:26 PM, Richard Henderson wrote: >> On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote: >>> +if (a->rt == 0) { >>> +tcg_gen_movi_i64(cpu_gpr[a->rd], 0); >>> +tcg_gen_movi_i64(cpu_gpr_hi[a->rd], 0); >>> +return

Re: [RFC PATCH 11/42] target/mips/tx79: Move PCPYH opcode to decodetree

2021-03-08 Thread Philippe Mathieu-Daudé
On 2/15/21 5:26 PM, Richard Henderson wrote: > On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote: >> +if (a->rt == 0) { >> +tcg_gen_movi_i64(cpu_gpr[a->rd], 0); >> +tcg_gen_movi_i64(cpu_gpr_hi[a->rd], 0); >> +return true; >> +} > > Is there a good reason not to use g

Re: [RFC PATCH 11/42] target/mips/tx79: Move PCPYH opcode to decodetree

2021-02-15 Thread Richard Henderson
On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote: > +if (a->rt == 0) { > +tcg_gen_movi_i64(cpu_gpr[a->rd], 0); > +tcg_gen_movi_i64(cpu_gpr_hi[a->rd], 0); > +return true; > +} Is there a good reason not to use gen_load_gpr? Otherwise, Reviewed-by: Richard Henderson

[RFC PATCH 11/42] target/mips/tx79: Move PCPYH opcode to decodetree

2021-02-14 Thread Philippe Mathieu-Daudé
Move the existing PCPYH opcode (Parallel Copy Halfword) to decodetree. Remove unnecessary code / comments. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tx79.decode | 5 + target/mips/translate.c | 39 target/mips/tx79_translate.c | 22