Re: [RFC PATCH 14/15] softmmu/cpus: Extract QMP command handlers to cpus-qmp.c

2021-05-26 Thread Richard Henderson
On 5/26/21 2:35 PM, Philippe Mathieu-Daudé wrote: On 5/26/21 9:10 PM, Richard Henderson wrote: On 5/17/21 4:55 AM, Philippe Mathieu-Daudé wrote: qmp_memsave() and qmp_pmemsave() call cpu_memory_rw_debug() and cpu_physical_memory_read(), which are target specific prototypes. Is there any reaso

Re: [RFC PATCH 14/15] softmmu/cpus: Extract QMP command handlers to cpus-qmp.c

2021-05-26 Thread Philippe Mathieu-Daudé
On 5/26/21 9:10 PM, Richard Henderson wrote: > On 5/17/21 4:55 AM, Philippe Mathieu-Daudé wrote: >> qmp_memsave() and qmp_pmemsave() call cpu_memory_rw_debug() >> and cpu_physical_memory_read(), which are target specific >> prototypes. > > Is there any reason they should be? They use target_ulong

Re: [RFC PATCH 14/15] softmmu/cpus: Extract QMP command handlers to cpus-qmp.c

2021-05-26 Thread Richard Henderson
On 5/17/21 4:55 AM, Philippe Mathieu-Daudé wrote: qmp_memsave() and qmp_pmemsave() call cpu_memory_rw_debug() and cpu_physical_memory_read(), which are target specific prototypes. Is there any reason they should be? In the short-term though, Reviewed-by: Richard Henderson r~

[RFC PATCH 14/15] softmmu/cpus: Extract QMP command handlers to cpus-qmp.c

2021-05-17 Thread Philippe Mathieu-Daudé
qmp_memsave() and qmp_pmemsave() call cpu_memory_rw_debug() and cpu_physical_memory_read(), which are target specific prototypes. To be able to build softmmu/cpus.c once for all targets, extract the QMP commands handlers to a new file which will be built per target. Signed-off-by: Philippe Mathieu