Re: [RFC PATCH 2/6] machine: Perform zero-check for the computed value of sockets

2021-07-13 Thread wangyanan (Y)
On 2021/7/12 23:30, Daniel P. Berrangé wrote: On Mon, Jul 12, 2021 at 05:00:48PM +0200, Andrew Jones wrote: On Fri, Jul 02, 2021 at 06:07:35PM +0800, Yanan Wang wrote: We currently perform zero-check (default the value to 1 if zeroed) for the computed values of cores/threads, to make sure they

Re: [RFC PATCH 2/6] machine: Perform zero-check for the computed value of sockets

2021-07-12 Thread Daniel P . Berrangé
On Mon, Jul 12, 2021 at 05:00:48PM +0200, Andrew Jones wrote: > On Fri, Jul 02, 2021 at 06:07:35PM +0800, Yanan Wang wrote: > > We currently perform zero-check (default the value to 1 if zeroed) > > for the computed values of cores/threads, to make sure they are at > > least 1. For consistency, we

Re: [RFC PATCH 2/6] machine: Perform zero-check for the computed value of sockets

2021-07-12 Thread Andrew Jones
On Fri, Jul 02, 2021 at 06:07:35PM +0800, Yanan Wang wrote: > We currently perform zero-check (default the value to 1 if zeroed) > for the computed values of cores/threads, to make sure they are at > least 1. For consistency, we probably should also default sockets > to 1 if the computed value is

[RFC PATCH 2/6] machine: Perform zero-check for the computed value of sockets

2021-07-02 Thread Yanan Wang
We currently perform zero-check (default the value to 1 if zeroed) for the computed values of cores/threads, to make sure they are at least 1. For consistency, we probably should also default sockets to 1 if the computed value is zero. Note that this won't affect any existing working cmdlines but