Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls

2021-06-07 Thread Eric Blake
On Fri, May 14, 2021 at 11:14:23PM +0200, Paolo Bonzini wrote: > On 14/05/21 15:13, Mirela Grujic wrote: > > However, if you believe it should rather be just renamed I can do so. > > I am just not sure it's such an advantage to replace phase_check with > separate functions. The rename is a

Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls

2021-05-14 Thread Paolo Bonzini
On 14/05/21 15:13, Mirela Grujic wrote: However, if you believe it should rather be just renamed I can do so. I am just not sure it's such an advantage to replace phase_check with separate functions. The rename is a constraint of QAPI, so we have to live with the long names. Paolo

Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls

2021-05-14 Thread Mirela Grujic
On 5/13/21 7:46 PM, Paolo Bonzini wrote: On 13/05/21 10:25, Mirela Grujic wrote: Once we define MachineInitPhase in qapi, the generated enumeration constants will be prefixed with the MACHINE_INIT_PHASE_. We need to define the MachineInitPhase enum in qapi in order to add the QMP command that

Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls

2021-05-13 Thread Paolo Bonzini
On 13/05/21 10:25, Mirela Grujic wrote: Once we define MachineInitPhase in qapi, the generated enumeration constants will be prefixed with the MACHINE_INIT_PHASE_. We need to define the MachineInitPhase enum in qapi in order to add the QMP command that will query current machine init phase.

[RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls

2021-05-13 Thread Mirela Grujic
Once we define MachineInitPhase in qapi, the generated enumeration constants will be prefixed with the MACHINE_INIT_PHASE_. We need to define the MachineInitPhase enum in qapi in order to add the QMP command that will query current machine init phase. Since in the existing definition of enum