Re: [RFC PATCH 3/4] hw/intc/gic: use MxTxAttrs to divine accessing CPU

2022-09-17 Thread Richard Henderson
On 9/16/22 17:28, Alex Bennée wrote: I pondered boolean but wasn't sure if that would blow up the size of MemTxAttrs so went for the bitfield. You can use bool with a bitfield. Though Phil's suggestion of .requestor_type has merit. That depends on what comes of Peter's hw modeling

Re: [RFC PATCH 3/4] hw/intc/gic: use MxTxAttrs to divine accessing CPU

2022-09-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 15/9/22 10:16, Richard Henderson wrote: >> On 9/14/22 17:09, Alex Bennée wrote: >>> Now that MxTxAttrs encodes a CPU we should use that to figure it out. >>> This solves edge cases like accessing via gdbstub or qtest. >>> >>> Signed-off-by: Alex Bennée >>>

Re: [RFC PATCH 3/4] hw/intc/gic: use MxTxAttrs to divine accessing CPU

2022-09-16 Thread Philippe Mathieu-Daudé via
On 15/9/22 10:16, Richard Henderson wrote: On 9/14/22 17:09, Alex Bennée wrote: Now that MxTxAttrs encodes a CPU we should use that to figure it out. This solves edge cases like accessing via gdbstub or qtest. Signed-off-by: Alex Bennée Resolves:

Re: [RFC PATCH 3/4] hw/intc/gic: use MxTxAttrs to divine accessing CPU

2022-09-15 Thread Richard Henderson
On 9/14/22 17:09, Alex Bennée wrote: Now that MxTxAttrs encodes a CPU we should use that to figure it out. This solves edge cases like accessing via gdbstub or qtest. Signed-off-by: Alex Bennée Resolves: https://gitlab.com/qemu-project/qemu/-/issues/124 --- hw/intc/arm_gic.c | 39

[RFC PATCH 3/4] hw/intc/gic: use MxTxAttrs to divine accessing CPU

2022-09-14 Thread Alex Bennée
Now that MxTxAttrs encodes a CPU we should use that to figure it out. This solves edge cases like accessing via gdbstub or qtest. Signed-off-by: Alex Bennée Resolves: https://gitlab.com/qemu-project/qemu/-/issues/124 --- hw/intc/arm_gic.c | 39 ++- 1 file