Re: [RFC PATCH 3/6] pc/machine: Perform zero-check for the value of -smp dies

2021-07-12 Thread wangyanan (Y)
On 2021/7/12 23:27, Andrew Jones wrote: On Mon, Jul 12, 2021 at 05:05:43PM +0200, Andrew Jones wrote: On Mon, Jul 12, 2021 at 05:04:04PM +0200, Andrew Jones wrote: On Fri, Jul 02, 2021 at 06:07:36PM +0800, Yanan Wang wrote: It's possible that dies parameter is explicitly specified as "dies=0"

Re: [RFC PATCH 3/6] pc/machine: Perform zero-check for the value of -smp dies

2021-07-12 Thread Andrew Jones
On Mon, Jul 12, 2021 at 05:05:43PM +0200, Andrew Jones wrote: > On Mon, Jul 12, 2021 at 05:04:04PM +0200, Andrew Jones wrote: > > On Fri, Jul 02, 2021 at 06:07:36PM +0800, Yanan Wang wrote: > > > It's possible that dies parameter is explicitly specified as "dies=0" > > > in the cmdline, if so we wi

Re: [RFC PATCH 3/6] pc/machine: Perform zero-check for the value of -smp dies

2021-07-12 Thread Andrew Jones
On Mon, Jul 12, 2021 at 05:04:04PM +0200, Andrew Jones wrote: > On Fri, Jul 02, 2021 at 06:07:36PM +0800, Yanan Wang wrote: > > It's possible that dies parameter is explicitly specified as "dies=0" > > in the cmdline, if so we will wrongly calculate the other ommited > > parameters such as "sockets

Re: [RFC PATCH 3/6] pc/machine: Perform zero-check for the value of -smp dies

2021-07-12 Thread Andrew Jones
On Fri, Jul 02, 2021 at 06:07:36PM +0800, Yanan Wang wrote: > It's possible that dies parameter is explicitly specified as "dies=0" > in the cmdline, if so we will wrongly calculate the other ommited > parameters such as "sockets = maxcpus / (dies * cores * threads);" > with a zeroed dies value. >

[RFC PATCH 3/6] pc/machine: Perform zero-check for the value of -smp dies

2021-07-02 Thread Yanan Wang
It's possible that dies parameter is explicitly specified as "dies=0" in the cmdline, if so we will wrongly calculate the other ommited parameters such as "sockets = maxcpus / (dies * cores * threads);" with a zeroed dies value. So perform zero-check (default the value to 1 if zeroed) for -smp die