Re: [RFC PATCH 6/6] hw/block/nvme: Make device target agnostic

2020-05-07 Thread Paolo Bonzini
On 07/05/20 12:04, Stefan Hajnoczi wrote: >>> (NVME_PMRCAP_PMRWBM(n->bar.pmrcap) & 0x02)) { >>> -qemu_ram_writeback(n->pmrdev->mr.ram_block, >>> - 0, n->pmrdev->size); >>> +memory_region_do_writeback(>pmrdev->mr, 0,

Re: [RFC PATCH 6/6] hw/block/nvme: Make device target agnostic

2020-05-07 Thread Stefan Hajnoczi
On Mon, May 04, 2020 at 05:36:22PM +0200, Philippe Mathieu-Daudé wrote: > +Keith new email > > On 5/4/20 11:46 AM, Philippe Mathieu-Daudé wrote: > > The NVMe device should not use target specific API. > > Use memory_region_do_writeback() (which was introduced > > in commit 61c490e25e0, after the

Re: [RFC PATCH 6/6] hw/block/nvme: Make device target agnostic

2020-05-04 Thread Philippe Mathieu-Daudé
+Keith new email On 5/4/20 11:46 AM, Philippe Mathieu-Daudé wrote: The NVMe device should not use target specific API. Use memory_region_do_writeback() (which was introduced in commit 61c490e25e0, after the NVMe emulated device was added) to replace qemu_ram_writeback(). Signed-off-by:

[RFC PATCH 6/6] hw/block/nvme: Make device target agnostic

2020-05-04 Thread Philippe Mathieu-Daudé
The NVMe device should not use target specific API. Use memory_region_do_writeback() (which was introduced in commit 61c490e25e0, after the NVMe emulated device was added) to replace qemu_ram_writeback(). Signed-off-by: Philippe Mathieu-Daudé --- RFC because I have no clue how dirty_log_mask