Re: [RFC PATCH v1 1/6] build-sys: Add rust feature option

2024-06-12 Thread Marc-André Lureau
Hi On Wed, Jun 12, 2024 at 12:05 PM Daniel P. Berrangé wrote: > On Tue, Jun 11, 2024 at 02:25:39PM -0400, Stefan Hajnoczi wrote: > > On Tue, 11 Jun 2024 at 13:54, Manos Pitsidianakis > > wrote: > > > > > > On Tue, 11 Jun 2024 at 17:05, Stefan Hajnoczi > wrote: > > > > > > > > On Mon, Jun 10,

Re: [RFC PATCH v1 1/6] build-sys: Add rust feature option

2024-06-12 Thread Daniel P . Berrangé
On Tue, Jun 11, 2024 at 02:25:39PM -0400, Stefan Hajnoczi wrote: > On Tue, 11 Jun 2024 at 13:54, Manos Pitsidianakis > wrote: > > > > On Tue, 11 Jun 2024 at 17:05, Stefan Hajnoczi wrote: > > > > > > On Mon, Jun 10, 2024 at 09:22:36PM +0300, Manos Pitsidianakis wrote: > > > > Add options for Rust

Re: [RFC PATCH v1 1/6] build-sys: Add rust feature option

2024-06-11 Thread Stefan Hajnoczi
On Tue, 11 Jun 2024 at 13:54, Manos Pitsidianakis wrote: > > On Tue, 11 Jun 2024 at 17:05, Stefan Hajnoczi wrote: > > > > On Mon, Jun 10, 2024 at 09:22:36PM +0300, Manos Pitsidianakis wrote: > > > Add options for Rust in meson_options.txt, meson.build, configure to > > > prepare for adding Rust

Re: [RFC PATCH v1 1/6] build-sys: Add rust feature option

2024-06-11 Thread Manos Pitsidianakis
On Tue, 11 Jun 2024 at 17:05, Stefan Hajnoczi wrote: > > On Mon, Jun 10, 2024 at 09:22:36PM +0300, Manos Pitsidianakis wrote: > > Add options for Rust in meson_options.txt, meson.build, configure to > > prepare for adding Rust code in the followup commits. > > > > `rust` is a reserved meson name,

Re: [RFC PATCH v1 1/6] build-sys: Add rust feature option

2024-06-11 Thread Alex Bennée
Stefan Hajnoczi writes: > On Mon, Jun 10, 2024 at 09:22:36PM +0300, Manos Pitsidianakis wrote: >> Add options for Rust in meson_options.txt, meson.build, configure to >> prepare for adding Rust code in the followup commits. >> >> `rust` is a reserved meson name, so we have to use an

Re: [RFC PATCH v1 1/6] build-sys: Add rust feature option

2024-06-11 Thread Stefan Hajnoczi
On Mon, Jun 10, 2024 at 09:22:36PM +0300, Manos Pitsidianakis wrote: > Add options for Rust in meson_options.txt, meson.build, configure to > prepare for adding Rust code in the followup commits. > > `rust` is a reserved meson name, so we have to use an alternative. > `with_rust` was chosen. > >

[RFC PATCH v1 1/6] build-sys: Add rust feature option

2024-06-10 Thread Manos Pitsidianakis
Add options for Rust in meson_options.txt, meson.build, configure to prepare for adding Rust code in the followup commits. `rust` is a reserved meson name, so we have to use an alternative. `with_rust` was chosen. Signed-off-by: Manos Pitsidianakis --- The cargo wrapper script hardcodes some